Repository navigation
fix: port rp2040 support for keyball39 - #882
Merged
Merged
Conversation
Yowkees
approved these changes
Sep 25, 2026
Yowkees
left a comment
Yowkees
left a comment
Owner
There was a problem hiding this comment.
#870でkeyball44に入れたRP2040用SPIピン定義(SPI_DRIVER/SPI_SCK_PIN/SPI_MOSI_PIN/SPI_MISO_PIN/SPLIT_HAND_MATRIX_GRID_LOW_IS_LEFT)と全く同じパターンをkeyball39にも展開する内容で、#ifdef MCU_RPでオプトインされているため既存のAVRビルドに影響はありません。実機(Elite Pi)でのビルド確認もされています。CIも成功しました。マージします、ありがとうございました!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the rp2040 fix made in #870 but for the keyball39. The original fix only included keyball44 since that's what they had to test with.
I just assembled the keyball39 using a pair of Elite Pi microcontrollers and used this patch to build the firmware on my board: