Skip to content

Complete HookSession input and gradient hook coverage - #129

Merged
Xmaster6y merged 2 commits into
mainfrom
codex/issue-115-hook-session-coverage
Aug 31, 2026
Merged

Xmaster6y merged 2 commits into
mainfrom
codex/issue-115-hook-session-coverage

Conversation

@Xmaster6y

Copy link
Copy Markdown
Owner

Summary

  • let HookSession.capture and HookSession.replace target forward inputs, including (args, kwargs) input hooks
  • expose both backward gradient-input and gradient-output directions while preserving the existing activation and gradient defaults
  • preserve structured input values and record each exact direction and target in the resulting HookProgram
  • document the expanded session API and cover success, failure, validation, structure preservation, and cleanup behavior

Validation

  • just checks
  • just tests — 621 passed, 1 skipped
  • uv run pytest tests/test_demo_notebooks.py -q -m integration — 3 passed, 1 deselected
  • just docs — passes with the existing AutoAPI cyclic-import warning

Closes #115

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-31T14:22:37.176389Z cc90792 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.31%. Comparing base (1e1b930) to head (9fcbda4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   98.30%   98.31%           
=======================================
  Files          52       52           
  Lines        3947     3968   +21     
=======================================
+ Hits         3880     3901   +21     
  Misses         67       67           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docs/source/notebooks/tutorials/hook-session.ipynb Outdated
@Xmaster6y
Xmaster6y merged commit aed555f into main Aug 31, 2026
6 checks passed
@Xmaster6y
Xmaster6y deleted the codex/issue-115-hook-session-coverage branch August 31, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete HookSession input and gradient hook coverage

1 participant