VCK190: notebook button-count fix and cleaner failure when display init fails - #1588
Open
ryanprovan wants to merge 2 commits into
Open
VCK190: notebook button-count fix and cleaner failure when display init fails#1588ryanprovan wants to merge 2 commits into
ryanprovan wants to merge 2 commits into
Conversation
added 2 commits
August 14, 2026 11:39
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pynq-next #1588 +/- ##
==========================================
Coverage 34.39% 34.39%
==========================================
Files 31 31
Lines 4774 4774
Branches 835 835
==========================================
Hits 1642 1642
Misses 3071 3071
Partials 61 61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix boards/VCK190/notebooks/board/register_map_intro.ipynb describing 4 push-buttons. Only 2 user push buttons are present as stated in the VCK190 user guide.
Fix a crash in the PYNQ video DRM driver (pynq/lib/video/drm.py) when the display device can't be set up. The code is supposed to stop and report an error, but the check for that never worked, so it carried on using a device that was never created and crashed instead. This fixes the check so it fails with a clear error message instead of killing the Python process. This affects any board where display initialisation fails — for example boards with no DisplayPort hardware.