Block Editor: Simplify InspectorControlsFill rendering logic - #81286
Merged
Conversation
|
Size Change: -6 B (0%) Total Size: 7.81 MB 📦 View Changed
|
im3dabasia
approved these changes
Aug 7, 2026
im3dabasia
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on the issue!
LGTM ✅
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I was experimenting with deferred inspector rendering and realized the component exit points became a bit hard to follow. This is my attempt to simplify it a little bit.
Changes
isSelectedBlock,isPatternEditing,isInListViewTree) instead of repeating symbol lookups.if/else if. The second check's condition was exactly theelsebranch of the first.rendersInListViewflag plus its own guard, so routing (which fill to use) is separate from gating (is this the selected block).StyleProviderwrapping either fill.childrenas JSX children rather than as a prop.Testing Instructions
I think this should have decent e2e test coverage, but a smoke test controls for various blocks - Navigation, Template Parts, Text blocks. Confirm they are rendered as before.
Testing Instructions for Keyboard
Same.
Use of AI Tools
Assisted by Claude.