RN: Add watch mode for native tests - #56788
Merged
Merged
Conversation
tyxla
added
[Type] Automated Testing
dcalhoun
approved these changes
Dec 5, 2023
dcalhoun
left a comment
dcalhoun
left a comment
Member
There was a problem hiding this comment.
I've generally relied upon passing --watch myself, but adding a dedicated script which aligns with the web test script makes sense to me. It will likely increase the visibility of this helpful feature. 👍🏻
I verified the native test scripts succeed as expected.
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 5, 2023
t-hamano
left a comment
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
I am using a Windows machine, but I have confirmed that it also works in the following environment 👍
- Host OS (Window 11)
- WSL2 (Ubuntu 20.04.4 LTS)
|
Flaky tests detected in a3f9dfa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7101900198
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
While working on #56758 I noticed that the RN tests don't come with a watch mode. This PR introduces one.
Why?
So you'd be able to run React native tests in watch mode, rather than re-running them every time.
How?
We're adding a new script that runs
test:nativeinjest--watchmode.Testing Instructions
npm run test:native:watchcorrectly runs React native tests in Jest watch mode.npm run test:nativestill works well.Testing Instructions for Keyboard
None
Screenshots or screencast
None