-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add async keyword to import functions #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asteurer
wants to merge
5
commits into
WebAssembly:main
Choose a base branch
from
asteurer:p3-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
88aa3cd
fix: remove wkg.lock
asteurer cd9e34e
feat: bump dependency versions
asteurer cb9b90b
feat: bump package version
asteurer f29f12f
feat: add async keyword to relevant import functions
asteurer c6c6878
fix: remove async keyword from tracing import functions
asteurer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| package wasi:clocks@0.2.11; | ||
|
|
||
| /// WASI Monotonic Clock is a clock API intended to let users measure elapsed | ||
| /// time. | ||
| /// | ||
| /// It is intended to be portable at least between Unix-family platforms and | ||
| /// Windows. | ||
| /// | ||
| /// A monotonic clock is a clock which has an unspecified initial value, and | ||
| /// successive reads of the clock will produce non-decreasing values. | ||
| @since(version = 0.2.0) | ||
| interface monotonic-clock { | ||
| @since(version = 0.2.0) | ||
| use wasi:io/poll@0.2.11.{pollable}; | ||
|
|
||
| /// An instant in time, in nanoseconds. An instant is relative to an | ||
| /// unspecified initial value, and can only be compared to instances from | ||
| /// the same monotonic-clock. | ||
| @since(version = 0.2.0) | ||
| type instant = u64; | ||
|
|
||
| /// A duration of time, in nanoseconds. | ||
| @since(version = 0.2.0) | ||
| type duration = u64; | ||
|
|
||
| /// Read the current value of the clock. | ||
| /// | ||
| /// The clock is monotonic, therefore calling this function repeatedly will | ||
| /// produce a sequence of non-decreasing values. | ||
| /// | ||
| /// For completeness, this function traps if it's not possible to represent | ||
| /// the value of the clock in an `instant`. Consequently, implementations | ||
| /// should ensure that the starting time is low enough to avoid the | ||
| /// possibility of overflow in practice. | ||
| @since(version = 0.2.0) | ||
| now: func() -> instant; | ||
|
|
||
| /// Query the resolution of the clock. Returns the duration of time | ||
| /// corresponding to a clock tick. | ||
| @since(version = 0.2.0) | ||
| resolution: func() -> duration; | ||
|
|
||
| /// Create a `pollable` which will resolve once the specified instant | ||
| /// has occurred. | ||
| @since(version = 0.2.0) | ||
| subscribe-instant: func(when: instant) -> pollable; | ||
|
|
||
| /// Create a `pollable` that will resolve after the specified duration has | ||
| /// elapsed from the time this function is invoked. | ||
| @since(version = 0.2.0) | ||
| subscribe-duration: func(when: duration) -> pollable; | ||
| } | ||
|
|
||
| /// WASI Wall Clock is a clock API intended to let users query the current | ||
| /// time. The name "wall" makes an analogy to a "clock on the wall", which | ||
| /// is not necessarily monotonic as it may be reset. | ||
| /// | ||
| /// It is intended to be portable at least between Unix-family platforms and | ||
| /// Windows. | ||
| /// | ||
| /// A wall clock is a clock which measures the date and time according to | ||
| /// some external reference. | ||
| /// | ||
| /// External references may be reset, so this clock is not necessarily | ||
| /// monotonic, making it unsuitable for measuring elapsed time. | ||
| /// | ||
| /// It is intended for reporting the current date and time for humans. | ||
| @since(version = 0.2.0) | ||
| interface wall-clock { | ||
| /// A time and date in seconds plus nanoseconds. | ||
| @since(version = 0.2.0) | ||
| record datetime { | ||
| seconds: u64, | ||
| nanoseconds: u32, | ||
| } | ||
|
|
||
| /// Read the current value of the clock. | ||
| /// | ||
| /// This clock is not monotonic, therefore calling this function repeatedly | ||
| /// will not necessarily produce a sequence of non-decreasing values. | ||
| /// | ||
| /// The returned timestamps represent the number of seconds since | ||
| /// 1970-01-01T00:00:00Z, also known as [POSIX's Seconds Since the Epoch], | ||
| /// also known as [Unix Time]. | ||
| /// | ||
| /// The nanoseconds field of the output is always less than 1000000000. | ||
| /// | ||
| /// [POSIX's Seconds Since the Epoch]: https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xbd_chap04.html#tag_21_04_16 | ||
| /// [Unix Time]: https://en.wikipedia.org/wiki/Unix_time | ||
| @since(version = 0.2.0) | ||
| now: func() -> datetime; | ||
|
|
||
| /// Query the resolution of the clock. | ||
| /// | ||
| /// The nanoseconds field of the output is always less than 1000000000. | ||
| @since(version = 0.2.0) | ||
| resolution: func() -> datetime; | ||
| } | ||
|
|
||
| @unstable(feature = clocks-timezone) | ||
| interface timezone { | ||
| @unstable(feature = clocks-timezone) | ||
| use wall-clock.{datetime}; | ||
|
|
||
| /// Information useful for displaying the timezone of a specific `datetime`. | ||
| /// | ||
| /// This information may vary within a single `timezone` to reflect daylight | ||
| /// saving time adjustments. | ||
| @unstable(feature = clocks-timezone) | ||
| record timezone-display { | ||
| /// The number of seconds difference between UTC time and the local | ||
| /// time of the timezone. | ||
| /// | ||
| /// The returned value will always be less than 86400 which is the | ||
| /// number of seconds in a day (24*60*60). | ||
| /// | ||
| /// In implementations that do not expose an actual time zone, this | ||
| /// should return 0. | ||
| utc-offset: s32, | ||
| /// The abbreviated name of the timezone to display to a user. The name | ||
| /// `UTC` indicates Coordinated Universal Time. Otherwise, this should | ||
| /// reference local standards for the name of the time zone. | ||
| /// | ||
| /// In implementations that do not expose an actual time zone, this | ||
| /// should be the string `UTC`. | ||
| /// | ||
| /// In time zones that do not have an applicable name, a formatted | ||
| /// representation of the UTC offset may be returned, such as `-04:00`. | ||
| name: string, | ||
| /// Whether daylight saving time is active. | ||
| /// | ||
| /// In implementations that do not expose an actual time zone, this | ||
| /// should return false. | ||
| in-daylight-saving-time: bool, | ||
| } | ||
|
|
||
| /// Return information needed to display the given `datetime`. This includes | ||
| /// the UTC offset, the time zone name, and a flag indicating whether | ||
| /// daylight saving time is active. | ||
| /// | ||
| /// If the timezone cannot be determined for the given `datetime`, return a | ||
| /// `timezone-display` for `UTC` with a `utc-offset` of 0 and no daylight | ||
| /// saving time. | ||
| @unstable(feature = clocks-timezone) | ||
| display: func(when: datetime) -> timezone-display; | ||
|
|
||
| /// The same as `display`, but only return the UTC offset. | ||
| @unstable(feature = clocks-timezone) | ||
| utc-offset: func(when: datetime) -> s32; | ||
| } | ||
|
|
||
| @since(version = 0.2.0) | ||
| world imports { | ||
| @since(version = 0.2.0) | ||
| import wasi:io/poll@0.2.11; | ||
| @since(version = 0.2.0) | ||
| import monotonic-clock; | ||
| @since(version = 0.2.0) | ||
| import wall-clock; | ||
| @unstable(feature = clocks-timezone) | ||
| import timezone; | ||
| } |
2 changes: 1 addition & 1 deletion
2
wit/deps/wasi-io-0.2.0/package.wit → wit/deps/wasi-io-0.2.11/package.wit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package wasi:io@0.2.0; | ||
| package wasi:io@0.2.11; | ||
|
|
||
| interface poll { | ||
| resource pollable { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| interface metrics { | ||
| use wasi:clocks/wall-clock@0.2.0.{datetime}; | ||
| use wasi:clocks/monotonic-clock@0.2.0.{duration}; | ||
| use wasi:clocks/wall-clock@0.2.11.{datetime}; | ||
| use wasi:clocks/monotonic-clock@0.2.11.{duration}; | ||
| use types.{key-value, instrumentation-scope, %resource}; | ||
| use tracing.{span-id, trace-id}; | ||
|
|
||
| /// Exports a resource's metric data. | ||
| %export: func(metrics: resource-metrics) -> result<_, error>; | ||
| %export: async func(metrics: resource-metrics) -> result<_, error>; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems plausibly useful to be async but I'd want to better understand what consuming this as async in opentelemetry-wasi would look like before we merge this. |
||
|
|
||
| /// An error resulting from `export` being called. | ||
| type error = string; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package wasi:otel@0.2.0-rc.2; | ||
| package wasi:otel@0.3.0-rc.1; | ||
|
|
||
| world imports { | ||
| import types; | ||
|
|
||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems plausibly useful to be async but I'd want to better understand what consuming this as async in opentelemetry-wasi would look like before we merge this.