Skip to content

Give the tools an 8MB stack on msvc #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nishuuzz wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Give the tools an 8MB stack on msvc #2815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,14 @@ function(wabt_executable)
add_dependencies(everything ${EXE_NAME})
target_link_libraries(${EXE_NAME} ${EXE_LIBS})

if (MSVC)
# The wast parser is recursive descent, so nesting depth costs stack, and
# real modules nest deeply: a switch lowers to a br_table wrapped in one
# block per case. msvc's 1MB default is not enough for that, so ask for
# the 8MB Linux and macOS give us.
target_link_options(${EXE_NAME} PRIVATE "/STACK:8388608")
endif ()

if (EMSCRIPTEN)
set(EXTRA_LINK_FLAGS
"${EXTRA_LINK_FLAGS} -sNODERAWFS -Oz -sALLOW_MEMORY_GROWTH"
Expand Down
Loading