[VEN-3360][VEN-3361]: VIP to configure Emode in the BNB core pool - #601
Merged
Conversation
GitGuru7
changed the title
GitGuru7
marked this pull request as ready for review
September 11, 2025 09:43
chechu
reviewed
Sep 11, 2025
kkirka
reviewed
Sep 12, 2025
kkirka
left a comment
kkirka
left a comment
Contributor
There was a problem hiding this comment.
bsctestnet addresses and commands LGTM
Contributor
|
Bsctestnet VIP LGTM |
chechu
reviewed
Sep 13, 2025
chechu
reviewed
Sep 13, 2025
chechu
reviewed
Sep 13, 2025
Contributor
|
bsctestnet addresses, cut params and commands LGTM. |
Contributor
chechu
reviewed
Sep 17, 2025
chechu
left a comment
chechu
left a comment
Contributor
There was a problem hiding this comment.
vips/vip-550/bsctestnet-addendum.ts lgtm
Contributor
|
VIP on testnet to add Spark emode group: https://testnet.bscscan.com/tx/0x9ba068604425cab4e034ddad57b3f776e86497af041a0cc945cca041385e8c24 |
web3rover
reviewed
Sep 23, 2025
Debugger022
self-requested a review
September 23, 2025 09:45
chechu
reviewed
Sep 23, 2025
chechu
left a comment
chechu
left a comment
Contributor
There was a problem hiding this comment.
Items reviewed on the mainnet vip:
- permissions (to be added, and to be removed)
- set CF, LT and LI for every market (Core pool and e-mode group)
- set treasury percentage for liquidation fees
- set
isBorrowAllowedon each market (Core pool and e-mode group) - cut params
- set the ComptrollerLens in the Comptroller
- upgrade implementations of
- Liquidator
- VAIController
- VTokens
- Unitroller
LGTM
Debugger022
reviewed
Sep 23, 2025
Contributor
|
bscmainnet addresses, commands and cut-params LGTM. |
Debugger022
previously approved these changes
Sep 23, 2025
kkirka
previously approved these changes
Sep 23, 2025
kkirka
left a comment
kkirka
left a comment
Contributor
There was a problem hiding this comment.
Addresses, risk params, cut params, commands LGTM
web3rover
previously approved these changes
Sep 23, 2025
chechu
dismissed stale reviews from web3rover, kkirka, and Debugger022
via
September 23, 2025 12:16
0e843ef
chechu
previously approved these changes
Sep 23, 2025
chechu
force-pushed
the
vip/ven-3361
branch
from
September 23, 2025 12:36
0e843ef to
130930a
Compare
Contributor
Author
chechu
approved these changes
Sep 26, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description