Skip to content

feat: replace the hub contract row with the operator address - #5804

Open
cuzz-venus wants to merge 1 commit into
mainfrom
feat/operator-address
Open

feat: replace the hub contract row with the operator address#5804
cuzz-venus wants to merge 1 commit into
mainfrom
feat/operator-address

Conversation

@cuzz-venus

Copy link
Copy Markdown
Contributor

Jira ticket(s)

VPD-1964

Changes

  • Replaced the "Hub contract" row in the Liquidity Hub info section with an "Operator address" row, since the hub contract address is always the vhToken address already shown right below it.
  • The operator address is read on-chain per hub and links to the chain explorer, like the other address rows.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bec6fd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dapp-preview Ready Ready Preview Sep 2, 2026 7:56am UTC
dapp-testnet Ready Ready Preview Sep 2, 2026 7:56am UTC
venus.io Ready Ready Preview Sep 2, 2026 7:56am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

The PR replaces the redundant Liquidity Hub contract row with an on-chain owner address presented as the operator address.

  • Adds an owner-address contract query and chain-aware React Query hook.
  • Displays the fetched address as an explorer link in Liquidity Hub information.
  • Adds API, hook, and rendering tests and updates translations and snapshots.

Confidence Score: 4/5

The PR appears safe to merge functionally, but the untranslated labels and repository-structure violation should be cleaned up.

The on-chain query and UI integration have no established blocking failure; the accepted findings are independently actionable localization and code-organization issues.

Files Needing Attention: apps/evm/src/libs/translations/translations/{ja,th,tr,vi,zh-Hans,zh-Hant}.json and apps/evm/src/clients/api/mocks/index.ts

Important Files Changed

Filename Overview
apps/evm/src/clients/api/queries/getLiquidityHubOperatorAddress/index.ts Adds a focused read of the hub contract's owner address; no concrete contract-integration failure was established.
apps/evm/src/clients/api/queries/getLiquidityHubOperatorAddress/useGetLiquidityHubOperatorAddress/index.ts Adds a chain- and hub-address-scoped query hook using a distinct cache key.
apps/evm/src/pages/LiquidityHub/LiquidityHubInfo/index.tsx Replaces the duplicate hub-address row with an operator explorer link and a placeholder while data is unavailable.
apps/evm/src/clients/api/mocks/index.ts Adds two operator-address mock functions to an aggregate module contrary to the repository's one-function-per-file rule.
apps/evm/src/libs/translations/translations/ja.json Adds the new label as an untranslated placeholder, matching the same issue in five other non-English catalogs.

Reviews (1): Last reviewed commit: "feat: replace the hub contract row with ..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 80.92% 52958 / 65439
🔵 Statements 80.92% 52958 / 65439
🔵 Functions 74.66% 1621 / 2171
🔵 Branches 85.96% 7814 / 9090
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/clients/api/index.ts 100% 100% 100% 100%
apps/evm/src/clients/api/queries/getLiquidityHubOperatorAddress/index.ts 100% 100% 100% 100%
apps/evm/src/clients/api/queries/getLiquidityHubOperatorAddress/useGetLiquidityHubOperatorAddress/index.ts 100% 100% 100% 100%
apps/evm/src/constants/functionKey.ts 100% 100% 100% 100%
apps/evm/src/pages/LiquidityHub/LiquidityHubInfo/index.tsx 100% 100% 100% 100%
Generated in workflow #14203 for commit bec6fd7 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant