[TF2] Play Huntsman/Fortified Compound's shaking animation immediately once overcharged - #1992
Open
Tkain wants to merge 1 commit into
Open
[TF2] Play Huntsman/Fortified Compound's shaking animation immediately once overcharged#1992Tkain wants to merge 1 commit into
Tkain wants to merge 1 commit into
Conversation
TF2 only changes bows' viewmodel animations when SendWeaponAnim is called. Right now, if we're charging a bow, we only call that when its current viewmodel animation finishes. This means we have to wait for the bow's normal charging animation to finish before we can start its overcharging animation. Because of this, bows' overcharging animations only start a few seconds after they become overcharged. This commit allows bows' overcharging animations to begin as soon as they becomes overcharged. It does this by allowing SendWeaponAnim to be called before a bow's charging animation finishes if it is overcharged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TF2 only changes a Huntsman or Fortified Compound's viewmodel animation when
CTFCompoundBow::SendWeaponAnimis called. Currently, if a bow is being charged,SendWeaponAnimis only called when the bow's animation finishes. This means a bow can only ever begin its overcharging animation once its normal charging animation reaches its loop point. Because of this, bows' overcharge animations only start a few seconds after they enter their overcharged state. Bows otherwise have no visual indicator of being overcharged, so this discrepancy can be misleading for players.This commit allows bows' overcharging animations to begin as soon as they becomes overcharged. It does this by allowing
SendWeaponAnimto be called before a bow's charging animation finishes if it is overcharged.