Repository navigation
fix(filter): commit pending external text input when pressing Done - #148
Merged
dragonx943 merged 1 commit intoOct 18, 2026
Merged
Conversation
The external/dynamic filter sheet only committed text fields on keyboard Enter (IME_ACTION_DONE) or focus loss. Tapping the sheet's Done button dismissed the view immediately, so the EditText's focus-loss callback never ran and the typed value was lost. Clear focus on the focused field before dismissing so the existing focus-loss commit fires synchronously, matching the Enter behaviour. Co-Authored-By: Hy3 <noreply@hy3.dev>
dragonx943
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IME_ACTION_DONE) or focus loss.EditText's focus-loss callback never ran and the typed value was silently discarded.dismiss(), forcing the existing focus-loss commit to fire synchronously — identical behaviour to pressing Enter.Root cause
In
filter/ui/external/FilterAdapter.kt,textDelegatecommits viasetOnEditorActionListener(IME_ACTION_DONE)andsetOnFocusChangeListener. The sheet's Done button (filter/ui/external/sheet/FilterSheetFragment.kt) calleddismiss()directly, tearing the view down before the focus-loss path could run.Fix
FilterSheetFragment.ktDone handler:binding.buttonDone.setOnClickListener { binding.recyclerView.findFocus()?.clearFocus() dismiss() }This covers all cases: keyboard open, keyboard closed-but-focused, and already-unfocused (no-op).
Notes
compileDebugKotlin/ CI build recommended to confirm before merge. OnlyFilterSheetFragment.ktchanged (localbuild.yml/AGENTS.mdintentionally left untracked).🤖 Generated with Claude Code