fix(frontend-api): update cached frontend settings when updating CORS origins - #12615
Closed
Tyagiquamar wants to merge 1 commit into
Closed
fix(frontend-api): update cached frontend settings when updating CORS origins#12615Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
gastonfournier
left a comment
gastonfournier
left a comment
Contributor
There was a problem hiding this comment.
The issue reported is really low value, so I'll close it. Thanks for the contribution anyway, but I believe fixing this issue is not worthwhile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12561
When
setFrontendCorsSettingsupdates CORS origins in the database, it previously leftthis.cachedFrontendSettingswith the stale pre-write settings fetched during validation. Consequently, subsequent calls togetFrontendSettings(true)(such as in CORS headers middleware) served outdated CORS configuration until the cache expired or was refreshed.Changes
FrontendApiService.setFrontendCorsSettings, assign the updated settings object tothis.cachedFrontendSettingsupon successful write.frontend-api-service.test.tsverifying thatsetFrontendCorsSettingsimmediately updates cached settings.