Open
Conversation
|
|
ivarconr
marked this pull request as ready for review
June 5, 2026 09:16
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Copilot
AI
changed the title
[WIP] Clean up completed safeguards feature flag
chore: remove Jun 5, 2026
safeguards feature flag
Member
|
@copilot can you sign the CLA? |
Contributor
Author
As an AI agent, I'm not able to sign a CLA directly. The human who initiated this PR (the repository owner or the user who triggered this Copilot coding agent session) would need to sign the CLA on behalf of these changes. |
sjaanus
reviewed
Jun 5, 2026
| const { releasePlans, refetch: refetchReleasePlans } = | ||
| useFeatureReleasePlans(projectId, featureId, featureEnvironment?.name); | ||
| const { trackEvent } = usePlausibleTracker(); | ||
| const safeguardsEnabled = useImpactMetricsEnabled(); |
Contributor
There was a problem hiding this comment.
I see the hook being used in other places. Could we run into issue that impact metrics is disabled and safeguard enabled now? Is that ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
safeguardsUnleash flag has been marked as completed with outcome kept, meaning the safeguards feature is fully released and the flag guard should be removed.Changes
EnvironmentAccordionBody.tsx: Removed thesafeguardsEnabledconditional that was gating theLazySafeguardcomponent behinduseImpactMetricsEnabled(). The component is now rendered unconditionally.The
useImpactMetricsEnabledhook is retained — it is still used byFeatureMetricsOverview,ImpactMetricsPage, andImpactMetricsAdmin.