Conversation
Contributor
|
Makes sense but this means clien-specification would be ESM too... and thus all the repos that depend on it... so this can potentially break node-sdk and js-sdk build processes (only if this project is used as a dependency) |
Contributor
Author
|
Indeed. Maybe hold off on this for now. |
Member
Agreed. This is also a silly place to be. The project itself is JSON. The fact that the Node SDK depends on a npm/yarn/pnpm install is an implementation detail which we should fix (at some point, not necessarily today) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chalk v6 is ESM now, so importing it needed to change