chore(uniswapx-sdk): rename multicallSameContractManyFunctions to ...ManyCalls

[ericneil-sanc]

Stacked on #685 — review/merge that first.

Problem

multicallSameContractManyFunctions doesn't call many functions. It resolves functionName to a single fragment once, outside the loop, then encodes one call per entry in functionParams:

const fragment = contractInterface.getFunction(functionName);   // one function
const calls: Call[] = functionParams.map((functionParam) => {   // many arg sets
  const callData = contractInterface.encodeFunctionData(fragment, functionParam);

It varies the arguments of one function, not the function. The structural giveaway is that functionName lives in the shared MulticallParams base type, so no helper extending it can vary the function at all:

Helper	address(es)	functionName	params	varies on
...SameContractManyFunctions	one	one	many	arguments
...SameFunctionManyContracts	many	one	one	contract

The sibling is named accurately; this one looks like it was named by symmetry without noticing the varying axis differs.

No capability is missing — multicall is exported and takes arbitrary {target, callData} pairs, so heterogeneous functions and contracts were always reachable. These two are narrow conveniences over it, one mislabeled.

Change

Renamed to multicallSameContractManyCalls. The old name stays exported as a deprecated alias:

export const multicallSameContractManyFunctions = multicallSameContractManyCalls;

Nothing breaks

Uniswap/fee-collector imports the old name and passes it as a first-class function reference to multicallSameContractChunked, so this had to stay source-compatible. The emitted declaration is typeof multicallSameContractManyCalls, which preserves the full generic signature — every call site and value position that accepted the old name still typechecks. Added a test asserting the alias is the same reference and still executes end-to-end.

Minor bump: additive export plus a deprecation, no removal.

bun test src/: 345 pass, 0 fail. Lint and build:types clean.

🤖 Generated with Claude Code

[graphite-app]

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (08/06/26)

1 assignee was added and 2 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation.

[github-actions]

_{● Reviewed · against a40d921 · 2026-08-07 16:30 UTC · view run ↗}

Note

Approved.

Renames multicallSameContractManyFunctions to multicallSameContractManyCalls and keeps the old name as a deprecated reference alias.

Assessment

The rename fixes a mislabel — the helper varies argument sets over one function, not the function itself. The alias is a direct reference assignment, so the emitted typeof re-export preserves the full generic signature and value-position consumers like fee-collector still typecheck. Internal callers in multicallOrdersPreservingOrder are updated consistently, and the added test asserts alias identity and end-to-end execution.

Tip

Teach the reviewer. React 👍 on findings that helped, 👎 on false positives. Reply to push back or add context — we aggregate this weekly to tune the bot.

Comment @request-claude-review to re-run.

[github-actions]

Note

✅ Approved — see full review in the sticky comment ↑