Conversation
…try; add `CloseProgressBar()` method; change to spaces and "LF"
|
Download the artifacts for this pull request here: GUI:
CLI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes it work noticeably faster (~40% in some cases, see below).
Fixes The code searching is not truly parallel (multithreaded) anymore. #2237.
I tested this on "123" search query in Deltarune Chapter 5 (UTMT built in the "Release" mode) and here is a comparison:
The first search, the second and third, in seconds:
Before: 2.160, 2.045, 1.392.
After: 1.523, 1.334, 0.710.
Added a new
CloseProgressBar()method; the progress bar window is properly closed (scriptDialog.TryClose()) instead of hiding it.Fixes Phantom progress bar windows on hover. #1616.
Fixed the "MainWindow.xaml.cs" formatting - now it's spaces ("SPC") and
\nline endings ("LF").Caveats
None.