Skip to content

Credit cool-lift hop time against the layer dwell - #2388

Open
JATMN (jatmn) wants to merge 3 commits into
Ultimaker:mainfrom
jatmn:fix-1630-cool-lift-hop-time
Open

JATMN (jatmn) wants to merge 3 commits into
Ultimaker:mainfrom
jatmn:fix-1630-cool-lift-hop-time

Conversation

@jatmn

@jatmn JATMN (jatmn) commented Sep 29, 2026 •

Copy link
Copy Markdown

Description

Fixes #1630.

cool_lift_head paused for the whole extra_time after hopping, even though the Z motion spends part of that interval. The dwell now subtracts the 3 mm lift time and a conservative return-time credit. The return credit accounts for a later extruder's hop speed, a possible next-layer wipe speed, and the next layer's Z. If the credited motion covers the extra time, no G4 is written. The hop commands themselves are unchanged.

The credit uses commanded feedrates and does not model Z acceleration.

Fork pull requests cannot publish the Conan package, because that job needs cura-conan2 credentials. This uses the same check_actor gate as the other open fork pull requests, so conan-package runs for same-repository pushes and pull requests and is skipped for a fork actor.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • At the previous head 7e7fe0c03e599891b59004956fde108ec6db7c1e, LayerPlanTest passed 1445/1445 and ctest passed 29/29 in the author's Conan environment.
  • The repair adds a faster-next-extruder dwell case and corrects both original cool-lift cases to assert an upward physical Z move. Changed-line clang-format --dry-run --Werror and git diff --check passed on the repair commit.
  • The updated LayerPlanTest and CTest suite have not run locally: the available Conan remote cannot resolve the required sentrylibrary/1.0.0 Python recipe. The author explicitly waived this gate for the PR update. The hosted unit job is skipped for this fork actor.

Previous test configuration: Debian 13, g++ 14.2.0, CMake 3.31.6, Conan 2.32.0, profile cura.jinja, Release, arcus and plugins disabled.

Reviewed repair commit: af5bcafafb1b74542e2a9dd264bc05b4339f7c6c

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

The lift and the matching drop already spend part of extra_time, so the G4 only covers the remainder.
@jatmn
JATMN (jatmn) marked this pull request as ready for review September 29, 2026 04:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Community Contribution 👑 Community Contribution PR's

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cool_lift_head dwell time does not account for time spent in hop

1 participant