Repository navigation
Credit cool-lift hop time against the layer dwell - #2388
Open
JATMN (jatmn) wants to merge 3 commits into
Open
JATMN (jatmn) wants to merge 3 commits into
JATMN (jatmn) wants to merge 3 commits into
Conversation
The lift and the matching drop already spend part of extra_time, so the G4 only covers the remainder.
6 of 8 tasks
JATMN (jatmn)
marked this pull request as ready for review
September 29, 2026 04:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1630.
cool_lift_headpaused for the wholeextra_timeafter hopping, even though the Z motion spends part of that interval. The dwell now subtracts the 3 mm lift time and a conservative return-time credit. The return credit accounts for a later extruder's hop speed, a possible next-layer wipe speed, and the next layer's Z. If the credited motion covers the extra time, noG4is written. The hop commands themselves are unchanged.The credit uses commanded feedrates and does not model Z acceleration.
Fork pull requests cannot publish the Conan package, because that job needs
cura-conan2credentials. This uses the samecheck_actorgate as the other open fork pull requests, soconan-packageruns for same-repository pushes and pull requests and is skipped for a fork actor.Type of change
How Has This Been Tested?
7e7fe0c03e599891b59004956fde108ec6db7c1e,LayerPlanTestpassed 1445/1445 andctestpassed 29/29 in the author's Conan environment.clang-format --dry-run --Werrorandgit diff --checkpassed on the repair commit.LayerPlanTestand CTest suite have not run locally: the available Conan remote cannot resolve the requiredsentrylibrary/1.0.0Python recipe. The author explicitly waived this gate for the PR update. The hosted unit job is skipped for this fork actor.Previous test configuration: Debian 13, g++ 14.2.0, CMake 3.31.6, Conan 2.32.0, profile
cura.jinja, Release, arcus and plugins disabled.Reviewed repair commit:
af5bcafafb1b74542e2a9dd264bc05b4339f7c6cChecklist: