-
-
Notifications
You must be signed in to change notification settings - Fork 932
CURA-13249 Merge header with first GCode part #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
666e6fa
Merge header with first GCode part
wawanbreton 70b3efd
Merge remote-tracking branch 'origin/main' into CURA-13249_fix_array_…
wawanbreton 5960a64
Restore gcode parts sending packets
wawanbreton b3473a4
Send missing end gcode part
wawanbreton fc40867
Clean code
wawanbreton 27ef614
Fix and consolidate end of gcode
wawanbreton 8712c03
Merge branch 'main' into CURA-13249_fix_array_data_structure
HellAholic f1b43ee
Merge branch 'main' into CURA-13249_fix_array_data_structure
HellAholic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCode-parts can't be empty here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't think in practice it could happen, because even if the print is somehow empty, you always have some init gcode.