[CURA-12917] Add a setting to continue bridging over support. - #2276
Open
Remco Burema (rburema) wants to merge 20 commits into
Open
[CURA-12917] Add a setting to continue bridging over support.#2276Remco Burema (rburema) wants to merge 20 commits into
Remco Burema (rburema) wants to merge 20 commits into
Conversation
This would help with keeping underside surfaces consistant, no matter where the support is generated. part of CURA-12917
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit 2b0fda5. ♻️ This comment has been updated with latest results. |
Casper Lamboo (casperlamboo)
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 4ecf97e | Previous: 1638756 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_local |
1.797587577548955 ns/iter |
1.1276244531308395 ns/iter |
1.59 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: Jelle Spijker (@jellespijker) Erwan MATHIEU (@wawanbreton) Casper Lamboo (@casperlamboo) HellAholic
…itions' into CURA-12917_bride_over_support_setting
CURA-12917 This is quite a refactoring to try and apply the briding areas and the overhanging areas the same way: instead of having custom processing, we now pre-calculate the areas where specific print settings should be applied, and give them to the LayerPlan who will take care of splitting the extrusion lines and applying the proper combination of settings where appropriate.
Erwan MATHIEU (wawanbreton)
changed the base branch from
main
to
CURA-13291_sharpen_bridging_conditions
September 8, 2026 08:32
…itions' into CURA-12917_bride_over_support_setting
…itions' into CURA-12917_bride_over_support_setting
Base automatically changed from
CURA-13291_sharpen_bridging_conditions
to
main
September 10, 2026 10:09
Erwan MATHIEU (wawanbreton)
approved these changes
Sep 10, 2026
Erwan MATHIEU (wawanbreton)
left a comment
Erwan MATHIEU (wawanbreton)
left a comment
Contributor
There was a problem hiding this comment.
Approved on behalf of Remco Burema (@rburema)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would help with keeping underside surfaces consistent, no matter where the support is generated.
Erwan MATHIEU (@wawanbreton): For this PR, we needed to introduce a method to print skin lines with different configs along the line. For this I added an
OverrideAreatype which can be used generically to change the config used for any extrusion line. Since this is the same mechanism used for overhanging areas, this part has also be refactored to used this new system.It cannot be used for the bridging walls calculation though, since those are more complex than just a simple area check.
See (also) front-end PR: Ultimaker/Cura#21341
CURA-12917