CURA-12446 top bottom wall count v3 - #21634
Open
Erwan MATHIEU (wawanbreton) wants to merge 7 commits into
Open
Conversation
Contributor
Test Results24 950 tests 24 888 ✅ 53s ⏱️ For more details on these failures, see this check. Results for commit 7a67728. ♻️ This comment has been updated with latest results. |
Contributor
Author
|
Unit tests are genuinely failing, have to fix some profiles |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Remco Burema (rburema)
approved these changes
Jun 4, 2026
Remco Burema (rburema)
left a comment
Remco Burema (rburema)
left a comment
Member
There was a problem hiding this comment.
Do we do the upgrader part as a separate bit, or does it belong with this ticket?
I'm fine with either, but if this is meant to be in 5.14, we should at least make a ticket.
Contributor
Author
Usually we do it separately, so I created the upgrade script ticket for 5.14 and linked this ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes a few existing settings and adds a bunch of new settings, regarding the walls counts:
CURA-12446
Requires Ultimaker/CuraEngine#2334
Supersedes #20565