-
Notifications
You must be signed in to change notification settings - Fork 56
fix(uipath-rpa): document both run/debug payload shapes (Helm vs Studio Desktop) and drop the --output-filter mandate #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ad78f43
fix(uipath-rpa): document the real run/debug payload shape and a null…
danmunteanu1 ca21626
fix(uipath-rpa): state the payload facts only, drop the unverifiable …
danmunteanu1 5e2c5e5
fix(uipath-rpa): align payload field descriptions with probed values …
danmunteanu1 c5b3324
fix(uipath-rpa): output field states in the read-order list match the…
danmunteanu1 326a29b
fix(uipath-rpa): drop the run/debug --output-filter mandate; the enve…
danmunteanu1 eaafcc1
fix(uipath-rpa): Failure envelope Message shapes, level-agnostic log …
danmunteanu1 a89d65a
fix(uipath-rpa): run/debug payload has two shapes selected by backend…
danmunteanu1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would the model know it has a running SD instance? It would probably query the processes list, right?
Also, I fear the
UIPATH_RPA_TOOL_USE_STUDIO=1part is outdated. cc @DragosUnguru @RaduAna-MariaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran additional tests with this branch rebased on latest main. The agent never writes about these details, it just runs the command and never comments about the output type, just observes the workflow succeeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does feel more confident about its output interpretation: