adding inv error to crit screen - #2100
Open
setaremalekiii wants to merge 24 commits into
Open
Conversation
Lucien950
requested changes
Jun 18, 2026
| static uint16_t prev_fl = 0u; | ||
| static uint16_t prev_rl = 0u; | ||
|
|
||
| static void update() |
Contributor
There was a problem hiding this comment.
this will not work, because the moment fr is set to something it will auto override everything else. please keep track of the errorcode/errored inverter in one variable
| // If higher priority error code is on we'll just keep that on first two segs are the | ||
| // inverter last 5 the code from CAN | ||
|
|
||
| if (fr_inv_error && fr_inv_error != prev_fr) |
Contributor
There was a problem hiding this comment.
this will display the error for one tick, then ignore it
Lucien950
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
Resolved Tickets