Therm Broadcast Fixes + ... - #2092
Open
KelmLelm wants to merge 18 commits into
Open
Conversation
Lucien950
requested changes
Jun 18, 2026
Lucien950
left a comment
Lucien950
left a comment
Contributor
There was a problem hiding this comment.
few things to look at, let's make sure this is on the car by ev active
| const bool balancing_enabled = app::can_rx::Debug_CellBalancing_Request_get(); | ||
|
|
||
| if (balancing_enabled && !ir_negative_open) | ||
| if (balancing_enabled && ir_negative_open) |
Contributor
There was a problem hiding this comment.
i think ir negative has to be closed for balancing by rules
Contributor
Author
There was a problem hiding this comment.
I think we gotta be hv up, but yeah ir negative closed is closer to rules
| #include <expected> | ||
|
|
||
| // Physical daisy-chain dimensions for this ECU. | ||
| inline constexpr uint8_t NUM_SEGMENTS = 10; |
Contributor
There was a problem hiding this comment.
this is breaking, make sure to merge asap
Comment on lines
+20
to
+23
| NUM_EXIT_CODES, | ||
| LUT_INVALID, | ||
| LUT_OVERSHOOT, | ||
| LUT_UNDERSHOOT |
Contributor
There was a problem hiding this comment.
also surely num at the end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
Resolved Tickets