[DX-2353] docs: clarify max_record_size and omit_detailed_recording do not apply to aggregate pumps - #2800
[DX-2353] docs: clarify max_record_size and omit_detailed_recording do not apply to aggregate pumps#2800sharadregoti wants to merge 2 commits into
Conversation
…apply to aggregate pumps
|
This pull request clarifies the documentation for Tyk Pump, specifying that the Files Changed Analysis
Architecture & Impact Assessment
flowchart LR
a["Aggregate pump settings documentation"] -- clarifies --> b["omit_detailed_recording"]
a -- clarifies --> c["max_record_size"]
b --> d["No effect on aggregate pumps"]
c --> d
Scope Discovery & Context Expansion
Metadata
Powered by Visor from Probelabs Last updated: 2026-08-26T14:14:58.515Z | Triggered by: pr_updated | Commit: 76a7c1d 💡 TIP: You can chat with Visor using |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Security Check PassedNo security issues found – changes LGTM. ✅ Performance Check PassedNo performance issues found – changes LGTM. ✅ Security Check PassedNo security issues found – changes LGTM. \n\n \n\n✅ Performance Check PassedNo performance issues found – changes LGTM. \n\n✅ Quality Check PassedNo quality issues found – changes LGTM. Powered by Visor from Probelabs Last updated: 2026-08-26T14:14:56.113Z | Triggered by: pr_updated | Commit: 76a7c1d 💡 TIP: You can chat with Visor using |
PR Code Suggestions ✨No code suggestions found for the PR. |
User description
Jira
DX-2353 -
max_record_sizeandomit_detailed_recordingare documented identically for every pump type, including aggregate pumps, but have no effect there.Change
Adds a caveat to the
pumps.mongoaggregate.omit_detailed_recording,pumps.mongoaggregate.max_record_size,pumps.sqlaggregate.omit_detailed_recording, andpumps.sqlaggregate.max_record_sizeentries on the Tyk Pump environment-variable reference, clarifying they have no effect on aggregate pumps because aggregated analytics records never includeraw_requestorraw_responsedata. A customer had followed the docs and setmax_record_sizeon an aggregate pump expecting it to control aggregate record size.Why this edits an auto-generated snippet
snippets/pump-config.mdxis normally synced from the Tyk Pump source. The durable fix is in tyk-pump#1090, which adds the same caveat to the originating Go struct doc comments inconfig.go. This PR applies the identical wording directly so the correction ships immediately, ahead of the next config-docs sync. Once tyk-pump#1090 merges, the next sync regenerates the same text, so there is no drift.PR Type
Documentation
Description
Clarify aggregate pump setting limitations
Note
omit_detailed_recordinghas no effectNote
max_record_sizehas no effectExplain aggregate records lack raw payloads
Diagram Walkthrough
File Walkthrough
pump-config.mdx
Document no-op settings for aggregate pumpssnippets/pump-config.mdx
pumps.mongoaggregate.omit_detailed_recordingpumps.mongoaggregate.max_record_sizepumps.sqlaggregatesettingsraw_requestandraw_response