Skip to content

🔄 Preview: [TT-17927] Update documentation for master - #2797

Draft
probelabs[bot] wants to merge 486 commits into
productionfrom
update/TT-17927/release-main-docs
Draft

🔄 Preview: [TT-17927] Update documentation for master#2797
probelabs[bot] wants to merge 486 commits into
productionfrom
update/TT-17927/release-main-docs

Merge main into update/TT-17927/release-main-docs

1eb36b6
Select commit
Loading
Failed to load commit list.
probelabs / Visor: technical-accuracy failed Aug 27, 2026 in 1m 7s

🚨 Check Failed

technical-accuracy check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 5
  • Error Issues: 4
  • Warning Issues: 1

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Documentation (4)

  • swagger/dashboard-swagger.yml:10308 - The description for the 403 Forbidden response of the /governance/evaluate endpoint states that an error can occur if "a requested api_id is not owned by the caller". This contradicts the parameter description for api_id (line 10269), which defines it as a "transient, caller-supplied identifier... does not need to match a stored API." An ownership check is not possible on a transient identifier that doesn't correspond to a stored entity.
  • swagger/dashboard-swagger.yml:16812 - The categories field in the SandboxEvaluationRequest schema has maxItems set to 10, but the description for the /governance/sandbox endpoint at line 10355 states that it accepts "one to twenty categories". This inconsistency will cause requests with 11-20 categories to be rejected by clients and validators that adhere to the schema.
  • snippets/gateway-config.mdx:2722 - The documentation for the new kv secret management feature has been added to the configuration files for the Dashboard, MDCB, and Pump, but it is missing from the Gateway's configuration file (gateway-config.mdx). The old kv.KV section was removed, but it was not replaced with the new standard kv documentation block. This omits documentation for a major, platform-wide feature from a key component.
  • ⚠️ swagger/dashboard-swagger.yml:12908 - The GovernanceComplianceData schema, used within a oneOf validator for notification data, does not have any required fields. This allows an empty object {} to validate against this schema, which can create ambiguity if other schemas in the oneOf list can also be satisfied by an empty object. This can break strict OpenAPI validators and code generators.

Logic (1)

  • system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 10310 in swagger/dashboard-swagger.yml

See this annotation in the file changed.

@probelabs probelabs / Visor: technical-accuracy

documentation Issue

The description for the 403 Forbidden response of the `/governance/evaluate` endpoint states that an error can occur if "a requested api_id is not owned by the caller". This contradicts the parameter description for `api_id` (line 10269), which defines it as a "transient, caller-supplied identifier... does not need to match a stored API." An ownership check is not possible on a transient identifier that doesn't correspond to a stored entity.
Raw output
Clarify the role of `api_id`. If it is truly transient and not used for ownership checks, remove the ownership clause from the 403 response description. If ownership is checked, the parameter description must be updated to reflect that `api_id` must match an existing API under certain conditions.

Check failure on line 16812 in swagger/dashboard-swagger.yml

See this annotation in the file changed.

@probelabs probelabs / Visor: technical-accuracy

documentation Issue

The `categories` field in the `SandboxEvaluationRequest` schema has `maxItems` set to 10, but the description for the `/governance/sandbox` endpoint at line 10355 states that it accepts "one to twenty categories". This inconsistency will cause requests with 11-20 categories to be rejected by clients and validators that adhere to the schema.
Raw output
Update the `maxItems` constraint in the schema to 20 to match the endpoint's description.

Check failure on line 2722 in snippets/gateway-config.mdx

See this annotation in the file changed.

@probelabs probelabs / Visor: technical-accuracy

documentation Issue

The documentation for the new `kv` secret management feature has been added to the configuration files for the Dashboard, MDCB, and Pump, but it is missing from the Gateway's configuration file (`gateway-config.mdx`). The old `kv.KV` section was removed, but it was not replaced with the new standard `kv` documentation block. This omits documentation for a major, platform-wide feature from a key component.
Raw output
Add the standard `kv` configuration documentation block to `snippets/gateway-config.mdx`, consistent with the documentation added to `snippets/dashboard-config.mdx`, `snippets/mdcb-config.mdx`, and `snippets/pump-config.mdx`.

Check warning on line 12908 in swagger/dashboard-swagger.yml

See this annotation in the file changed.

@probelabs probelabs / Visor: technical-accuracy

documentation Issue

The `GovernanceComplianceData` schema, used within a `oneOf` validator for notification data, does not have any `required` fields. This allows an empty object `{}` to validate against this schema, which can create ambiguity if other schemas in the `oneOf` list can also be satisfied by an empty object. This can break strict OpenAPI validators and code generators.
Raw output
Add `required: [api_id, ruleset_id, status]` to the `GovernanceComplianceData` schema to ensure that it only matches well-formed objects, making the `oneOf` validation deterministic.