Harden publish dependency installation - #200
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 9 9
Lines 2074 2074
Branches 428 428
=======================================
Hits 1746 1746
Misses 322 322
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
Why
The publish job has id-token write permission, so allowing arbitrary dependency lifecycle scripts during installation gives compromised transitive dependencies code execution in a privileged release context. Yarn's ignore-scripts flag makes that install fail closed without changing the non-privileged test workflow.
Tracks PLA-315.
Validation
The full local test suite was also attempted from the scripts-disabled install. SQLite-backed tests cannot load sqlite3 because its native binding is installed by a lifecycle script; this is expected for the hardened publish environment, which only builds releasable packages. The ordinary test workflow remains unchanged and continues to install the binding.