Repository navigation
Conversation
Greptile code reviewThis repo uses Greptile for automated review. Before merge, aim for Confidence Score: 5/5 with zero unresolved review threads — see CONTRIBUTING.md. Run a review — add a PR comment with: Give it ~5-10 minutes (sometimes longer) for results, then fix feedback and re-trigger until you reach Confidence Score: 5/5. Optional: automate with the greploop skill. |
|
@greptile review @codex review Stacked draft on #6994; please review only the calibration/reporting increment against its base branch. Focus on provenance, missing/failing judgment accounting, human-rating isolation and scorecard correctness. All proposed SRE judgments and successful live baseline results remain explicitly pending. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0a8f64da3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
[Medium impact] The reviewed changes appear safe to merge, subject to the stated stacked-PR process. SummaryAdds authored judge-calibration packs, human/judge comparisons, and offline scorecards for saved investigator runs.
Reviews (2) · Last reviewed commit: "test(triage): expose missing generation ..." · Reviewed by Greptile |
|
@codex review Fixed the generation-contract accounting finding in 9455b48 with an interrupted-judging regression. Prefix failures now count all recorded generation attempts, including attempts never reached by the judge. The updated 14 calibration/reporting tests and strict scoped mypy pass; the stacked base and pending human/live validation remain unchanged. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@greptile review Addressed missing-class coverage in b941db9. Class scorecards show planned/recorded/missing counts, including zero-run classes from a verified case dataset or an explicit unclassified selected-case bucket when the original dataset is unavailable. Empty classes have no duration/semantic score. Both paths are covered by regressions; 16 calibration/reporting tests and strict scoped mypy pass. |
Stacked on #6994. Base branch:
codex/triage-investigation-eval-baseline, so this PR shows only the calibration/reporting increment. Keep draft; merge the parent first, then rebase ontomainand retarget after it lands.Related: #6837, #6800, #6726.
Describe the changes you have made in this PR -
Make the evaluation baseline reviewable by an SRE and make saved results easier to assess before changing the investigator.
nullagreement, not perfect agreement.What remains pending: actual SRE case review/ratings, human/judge agreement, and successful repeated live investigator/judge runs. This PR adds the workflow and scorecard; it does not claim a calibrated judge, an established baseline v0, or production accuracy. The prior model smoke was blocked by the environment proxy. All source fixture review statuses remain unchanged.
Demo/Screenshot for feature changes and bug fixes -
Real offline pack preparation and comparison with an explicitly stubbed judge:
The scorecard CLI also consumed the parent's retained partial-generation smoke plus offline-stub judge artifact and preserved the partial generation status.
Validation
b941db9d4, zero unresolved threads. Codex follow-up on9455b4846found no further issues; the subsequent change addresses only Greptile coverage feedback.main. Keep this PR stacked; full CI must run after retargeting tomainonce test(triage): establish investigation evaluation baseline #6994 lands. Local passing checks below are not represented as remote CI.uv run --no-sync python -m pytest tests/core/telemetry: 48 passed, including 16 new calibration/reporting cases.--check-untyped-defs --disallow-untyped-defs) on the three new Python modules/tests: passed.make pre-push ARGS='--base codex/triage-investigation-eval-baseline': lint/format passed.Code Understanding and AI Usage
Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?
If you used AI assistance:
Explain your implementation approach:
AI-assisted implementation and self-review; maintainer/SRE review remains outstanding. Reuse the parent's generation/scoring formats and isolated judge. Keep authored calibration examples explicitly distinct from investigator outputs. Compare ordinal preferences within a case instead of treating human and judge score scales as interchangeable. Human judgments are external inputs with attribution and snapshot binding; the implementation does not supply or fabricate them.
Checklist before requesting a review
This is a stacked draft for iteration, not a request to merge either PR.