Repository navigation
fix(analytics): redact dynamic route values - #672
Merged
Merged
Conversation
The release review identified route values that can reach screen-view analytics. Pin the leak before changing route tracking. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
Numeric-only sanitization allowed release tags and protection names into screen-view events. Use the matched router template and fail closed when it is absent or mismatched so analytics never receives a private path value. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
github-actions
Bot
added
area:ui
Match the Dart formatter so the privacy regression suite can reach analysis and tests in CI. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03-ai
approved these changes
Oct 24, 2026
sjungwon03-ai
left a comment
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: Complete diff, router integration, fail-closed route sanitization, privacy notices, and analytics regression coverage for dynamic names, encoded slashes, query values, and unmatched routes.
- Checks: Current-head CI passed formatting, analysis, tests, generated-code verification, language policy, and iOS SDK validation; triage passed with the unrelated issue job skipped.
No blocking issues found. Flutter and Dart are unavailable locally, so test execution was verified through the current-head CI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
0.1.10release review found that visiting release, container-tag, and protection-detail routes can send private names to screen-view analytics. The regression test failed on the previous sanitizer:customer-secretappeared in the reported route. The fix uses the matched go_router route template and fails closed when no safe template is available. Root and bundled privacy notices now describe this behavior.Closes #671
Validation
git diff --checkpasses./:unknown, got/projects/:id/releases/customer-secret.Flutter and Dart are unavailable in this local environment, so the red and green test runs will be verified by CI.