[sjungwon03]

Summary

Existing group-based project protected-environment approval rules can now switch
between direct membership and inherited membership. Only explicitly reported
0/1 settings on known group rules are editable. The dialog shows the current
membership, group/rule IDs and approval count, then requires a changed choice,
the exact environment name and acknowledgement. It warns about expanding
approver eligibility or blocking deployments when narrowing it.

Complete paginated inventory and strict detail preflight precede one PUT with
only the target rule ID and group_inheritance_type. Strict response comparison
and an authoritative read-back preserve the group, approval count, every other
approval/deploy grant and legacy count. Writes never follow redirects or replay
authentication; uncertainty requires inspection and renewed confirmation, and
account replacement isolates late results.

Closes #654

Validation

• dart format --output=none --set-exit-if-changed . (999 files, no changes)
• flutter analyze --no-pub reports no issues; CI English language policy passes
• App and every package test suite pass: app 4,747; API 3,284; design system 135; models 204; secure storage 5 (8,375 total)
• API, controller and UI tests observed failing before implementation
• Related new/existing approval UI/controller suite: 105 tests pass
• Localization generated with flutter gen-l10n; models unchanged
• Five locales, 320/800/1200 widths, both themes and both edit directions;
  unknown/unchanged/non-group targets, stale/ambiguous environments,
  preservation, uncertainty, overlap, pending locking and account replacement.
• Synthetic widget validation only; no live GitLab role/tier/version validation.

Checklist

• Targets dev; independent branch from latest origin/dev
• Linked issue with Closes #654
• Conventional Commit title and DCO sign-off
• Behavior documentation, screenshot evidence and MW-02 tracking updated
• Mobile/tablet/desktop, light/dark coverage
• No dependencies, model changes, or external assets added; notices unchanged
• Dummy credentials, reserved example domains and fixture-only screenshots
• English repository content except supported localization resources

Screenshots

Synthetic widget captures with real local fonts, scrolled to confirmation:

Viewport	Light	Dark
Mobile
Desktop

Notes for reviewers

GitLab defines group_inheritance_type 0 as direct membership only and 1 as
including inherited groups. Premium/Ultimate, project CI/CD, appropriate
management permissions and shared-group eligibility remain server requirements.
This slice does not enumerate approvers or infer whether approval counts can
be satisfied. Group-level rules and unreported/future membership values remain
read-only; user/role grants and group replacement are separate work.

The existing strict approval-group reader is reused. A changed response or
read-back in any other modelled field is an unconfirmed write, requiring fresh
inspection. The endpoint offers no atomic compare-and-set, so another actor can
still change the rule between requests. Unknown server metadata is outside the
modelled preservation comparison. No model code generation is needed.

References: group inheritance,
protected-environment update,
implementation notes.

[sjungwon03-ai]

Review summary

Verdict: Approved

• Reviewed: protected-environment approval-group inheritance edit flow, API write guards, and regression coverage
• Checks: GitHub CI passed