Repository navigation
chore(security): require one approval before merging - #13
Merged
Merged
Conversation
Pull requests merged without review because required_approving_review_count was 0. That was a deliberate bootstrap choice — with a single account, requiring an approval makes every pull request unmergeable, since GitHub does not let you approve your own. There are now two accounts on the repository, so the gate is enforceable and is turned on. - required_approving_review_count: 0 -> 1 on dev and main-release - dismiss_stale_reviews_on_push and require_last_push_approval enabled, so an approval does not carry over to commits pushed after it The live rulesets were updated first; this brings the checked-in definitions back in sync and documents the change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
github-actions
Bot
added
area:ci
sjungwon03-ai
approved these changes
Aug 18, 2026
sjungwon03-ai
left a comment
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Correct follow-up to the bootstrap note in #2: with two accounts on the repo the approval gate is now enforceable. Verified against the live rulesets — both dev (20967376) and main-release (20967377) already report approvals=1, dismiss_stale=true, last_push=true, so the checked-in JSON now matches reality exactly. The rest of the diff is just GitHub's pretty-printed JSON reformat with identical values. README updated to match. This PR requiring a non-author approval is itself the gate working. LGTM.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull requests were merging without review. The
devandmain-releaserulesets hadrequired_approving_review_count: 0, so the pull-request rule enforced "must go through a PR" butnot "must be reviewed".
That zero was a deliberate bootstrap choice: with a single account, requiring an approval makes
every pull request unmergeable, because GitHub does not let you approve your own. There are now two
accounts on the repository (
sjungwon03,sjungwon03-ai), so the gate is enforceable.Change
required_approving_review_countdismiss_stale_reviews_on_pushrequire_last_push_approvalThe last two mean an approval does not carry over to commits pushed after it — what was reviewed is
what merges.
The live rulesets are already updated (they enforce immediately regardless of this file). This
PR brings the checked-in definitions under
.github/rulesets/back in sync and updates the README.This PR is its own proof
It cannot be merged without an approval from an account other than its author. That is the gate
working.
Checklist
devgit commit -s(DCO)Notes for reviewers
Earlier merges (#4, #6, #7, #8, #11) went in with zero approvals under the old setting. Nothing to
undo there, but that is why they merged without review.