feat(desktop): add renderer-owned Realtime Talk transport - #80
Open
TheAngryPit wants to merge 2 commits into
Open
feat(desktop): add renderer-owned Realtime Talk transport#80TheAngryPit wants to merge 2 commits into
TheAngryPit wants to merge 2 commits into
Conversation
Open
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in Desktop Realtime Talk transport that keeps Hermes Core as the single chat authority while using a provider Realtime session only for low-latency speech input and playback.
This advances #44 and depends on the narrow Hermes Desktop composer ownership contract in NousResearch/hermes-agent#100666.
Problem
The plugin's existing Desktop flow cannot safely take microphone ownership while the built-in wake listener is active. It also cannot submit finalized speech or observe the canonical assistant response through a supported renderer contract.
Using the relay's normal automatic-response mode would create a second answer authority: the provider could answer the user directly, independently of Hermes chat, and could receive a provider tool catalog that the renderer transport does not need.
Design
The change is split into two reviewable commits inside this PR:
Renderer-only session minting
desktop-relaysession mode;automatic_response=false;Desktop controller lifecycle
composer.actionsrender contribution;response_idand clears local/provider audio buffers;Core owns microphone/wake/composer coordination. The plugin owns provider session minting, WebRTC, audio playback, interruption, and UI state.
Security and authority boundary
Testing
Focused Desktop behavior:
tests/test_desktop_plugin.py— 6/6 passed;tests/test_desktop_turn_interruptions.py— 7/7 passed;Broader local validation:
private, which is also present in the standard macOS temporary-directory root; it is unrelated to this change;node --check desktop/plugin.js— passed;uv build— passed;git diff --check— passed.Manual validation still required
A live microphone/WebRTC canary requires a Hermes Desktop build containing the Core dependency and explicit microphone permission. It should cover:
No live service, installed plugin, credentials, or user configuration was modified while preparing this PR.
Related
NousResearch/hermes-agent#77111