fix(#2456): run the control-plane and knowledge-flow migration jobs by default - #2457
Merged
Merged
Conversation
…y default Both defaults still said "Enable when <backend> gets Alembic migrations" - stale for months: each backend owns a tree (alembic_version_control_plane, alembic_version_knowledge_flow). The consequence used to be silent, because knowledge-flow's startup create_all bootstrapped its own schema; #2314 removed it, so a fresh install with the chart defaults now crashloops on "[SCHEMA] knowledge-flow: required table(s) missing". Enabling only knowledge-flow would not be enough either: its REQUIRED_TABLES include users/teammetadata, migrated by the control-plane tree. No template change - the pre-install/pre-upgrade hook already runs the Job before the new pods roll. prism prod/int override both to true already, so this only aligns the published defaults with what real deployments do. Closes #2456
Contributor
Author
|
Rolled back before the release: the defaults stay off by design, only the stale comments are fixed. Tracked back on #2456. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolled back - this change is not the one we want. The chart's migration
defaults stay
falseon purpose: a platform overlay either turns the Job on inits own values or runs the upgrade imperatively. Only the stale comments needed
fixing, which is now the whole scope of #2456.
Original description below, kept for the record.
Since #2314 knowledge-flow creates no table at startup - both entrypoints call
require_tables(REQUIRED_TABLES)and refuse to boot on an unmigrated database.The chart's
knowledge-flow-backendandcontrol-plane-backendvalues stillcarried
migration.enabled: falsecommented "Enable when gets Alembicmigrations", which has been false for months.
This PR flipped both defaults to
true. That part is reverted; the comment fixlands separately.