Repository navigation
Conversation
…orted vehicles remain
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Teslemetry vehicle selection flow now excludes vehicles explicitly marked as non-proxy, removes already-added VINs, and selects an abort reason based on whether supported vehicles exist. ChangesVehicle selection flow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The vehicle flow distinguishes unsupported vehicles from supported vehicles that are already added. No material merge risk was identified; proceed with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Firstmate: superseded by upstream home-assistant#184521 (frenck), which fixed the same dev test failure and is merged. |
Breaking change
Proposed change
Dev has been red since home-assistant#184216 and home-assistant#184223 merged together: the local vehicle add flow chose
all_vehicles_addedwhenever the account had any vehicle and none was selectable, so an account whose only vehicles lack command protocol support (hidden by home-assistant#184223) was told they were all added. The flow now aborts withall_vehicles_addedonly when a supported vehicle exists and every supported one is already added, and withno_vehiclesotherwise, which is whattest_subentry_add_flow_only_unsupported_vehiclesexpects.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: