Repository navigation
Feat/eval gate - #3247
Closed
Hone125 wants to merge 2 commits into
Closed
Feat/eval gate#3247Hone125 wants to merge 2 commits into
Hone125 wants to merge 2 commits into
Conversation
…etection Add a dependency-free evaluation quality gate: an internal/evalgate package that compares a run's metrics against a stored baseline and a per-metric tolerance, a cmd/evalgate CLI, and a CI workflow that proves the gate blocks a recall regression (exit 1) and passes a healthy run (exit 0) with no model key required. The package deliberately imports no types package so go test stays free of the cgo-heavy gojieba dependency. The judge fails closed on a missing baseline/current metric, invalid values, and non-successful tasks, and reports regressions in deterministic (lexicographic) order.
- Extract long JSON fixtures in cmd/evalgate tests into named consts so no line exceeds the lll 120-column limit (tab-width 4). - Correct the CLI doc comment that referenced scripts/eval-gate.sh, which is not part of this change, and note it lands in a follow-up PR. - Fix two stale comments in internal/evalgate tests that described "skip, do not fail" while the code actually fails closed. - Rework TestJudgeGate_Pass to cover metrics that drop but stay within tolerance, which the gate must still accept. - Discard fmt.Fprintf/Fprintln return values (errcheck) and use the 0o600 octal literal (gofumpt) so golangci-lint reports no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issue
Fixes #
Testing
Checklist
git diff --check origin/main...HEADpassesgolangci-lint run --new-from-rev=origin/main ./...)docs/, Swagger annotations, etc.)Screenshots / Recordings