Mark destructors as constexpr for C++20 - #181
Open
dengzhongyuan365-dev wants to merge 1 commit into
Open
Conversation
C++20 allows constexpr destructors (P0718R2). This enables tl::expected to be used in compile-time contexts (consteval/constexpr). Add TL_EXPECTED_20_CONSTEXPR macro and apply it to all user-defined destructors in expected_storage_base specializations. Fixes TartanLlama#104
dengzhongyuan365-dev
marked this pull request as ready for review
June 30, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expected_storage_baseasconstexprfor C++20, enablingtl::expectedto be used in compile-time contexts (consteval/constexpr)Changes
include/tl/expected.hppTL_EXPECTED_20_CONSTEXPRmacro; applied it to 4 user-defined destructorsTest Plan
CMAKE_CXX_STANDARD=20) — compiles cleanly= defaultdestructors left unchanged (compiler handles them automatically)Fixes #104