Repository navigation
Normalize rank-recipient responses on read instead of on write #14024
Description
The current student-deletion flow in UsersLogic.deleteStudentCascade calls FeedbackResponsesLogic.updateRankRecipientQuestionResponsesAfterDeletingStudent to renumber rank-recipient answers after a student is deleted.
This is brittle because consistency of data is now handled primarily by the DB (via foreign key constraints), we no longer manually cascade updates or deletions in the logic layer. It is easy to have paths where a student is deleted but updateRankRecipientQuestionResponsesAfterDeletingStudent is not called.
Proposed Solution
Move the rank compaction behaviour to an appropriate location along the read path instead of normalising on write.
Activity
prachitjain commentedon Jun 22, 2026
Hi @samuelfangjw, I think I can solve this task. Can you tell me if this is still open?
samuelfangjw commentedon Jun 22, 2026
@prachitjain This is better left for contributors who are intimately familiar with the codebase.
prachitjain commentedon Jun 22, 2026
@samuelfangjw Okay, then I'll leave this. By the way, Is there any "good first issue" task or any task with relatively easy difficulty that I can contribute to? This is my first time in open source .
samuelfangjw commentedon Jun 22, 2026
@prachitjain could give this a try. #13454
MayurK-cmd commentedon Sep 2, 2026
Would love to work on this!