Fix variant selection on product detail page - #23
Open
shochdoerfer wants to merge 1 commit into
Open
Conversation
Member
crydotsnake
suggested changes
Aug 10, 2026
shochdoerfer
force-pushed
the
fix/variant_selection
branch
from
August 10, 2026 06:28
a7603bf to
2be4512
Compare
crydotsnake
approved these changes
Aug 10, 2026
jkindly
approved these changes
Aug 21, 2026
Contributor
|
The trait is already provided by the parent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
The
AddToCartFormComponentclass re-uses theComponentWithFormTraiteven though it extends the Sylius base component which already uses it. This creates two separate copies of the private properties and private methods which seems to cause an issue. Removing the trait fixes the issue, the variant selector is now properly refreshing the summary component again.