Remove dead ChatLLM.cpp speech-to-text code - #13757
Merged
Merged
Conversation
The ChatLLM.cpp engine was disabled in f17b638 (2026-03-09) by commenting out the only "Engines.Add(new ChatLlmCppEngine())" call, which made the engine and everything hanging off it unreachable. Removed: - ChatLlmCppEngine and its help-text asset - ChatLlmDownloadService (DownloadEngine was only called from the dead branch; the two Qwen3-ASR model methods had no callers at all - the live Qwen3 ASR engine uses IQwen3AsrCppDownloadService) - the four "is ChatLlmCppEngine" branches in SpeechToTextViewModel and DownloadSpeechToTextEngineViewModel, plus ReInsertPeriodsEtc() which only the ChatLLM transcription path called - WhisperChoice.ChatLlm and SeAudioToText.CommandLineParameterChatLlm Closes #13755 - the dependency bump would have meant rebuilding binaries for three platforms for code no user can reach. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13755.
The dependency bot asked us to move ChatLLM from
chatllm-2025-02-04tov24, which would mean rebuilding binaries for Windows, macOS-ARM and Linux. But the engine has been unreachable since f17b638 (2026-03-09), which disabled it by commenting out the only construction site://Engines.Add(new ChatLlmCppEngine());Since that was the sole place
ChatLlmCppEnginewas ever instantiated, everything hanging off it was dead. This deletes it rather than bumping a dependency no user can reach.Removed
ChatLlmCppEngineand itsChatLLM.cpp.txthelp-text assetChatLlmDownloadService+ DI registration —DownloadEngine()was only called from the dead branch, andDownloadModelQwen3AsrSmall/Large()had no callers at all (the live Qwen3 ASR engine usesIQwen3AsrCppDownloadService)is ChatLlmCppEnginebranches inSpeechToTextViewModel/DownloadSpeechToTextEngineViewModel, plusReInsertPeriodsEtc()which only the ChatLLM transcription path calledWhisperChoice.ChatLlmandSeAudioToText.CommandLineParameterChatLlmNet 495 lines removed, 3 added.
grep -ri chatllm src/is now empty. UI, UITests and LibUiLogicTests all build clean.🤖 Generated with Claude Code