Add StringBuilderExtensions, consolidate StringBuilder helpers

src/libse/Common/StringBuilderExtensions.cs

@@ -0,0 +1,95 @@
+using System.Text;
+
+namespace Nikse.SubtitleEdit.Core.Common
+{
+    public static class StringBuilderExtensions
+    {
+        /// <summary>
+        /// Trims leading/trailing whitespace inside the builder - the "sb.ToString().Trim()"
+        /// idiom allocates the whole output an extra time.
+        /// </summary>
+        public static void Trim(this StringBuilder sb)
+        {
+            while (sb.Length > 0 && char.IsWhiteSpace(sb[sb.Length - 1]))
+            {
+                sb.Length--;
+            }
+
+            var start = 0;
+            while (start < sb.Length && char.IsWhiteSpace(sb[start]))
+            {
+                start++;
+            }
+
+            if (start > 0)
+            {
+                sb.Remove(0, start);
+            }
+        }
+
+        public static bool StartsWith(this StringBuilder sb, char c)
+        {
+            return sb.Length > 0 && sb[0] == c;
+        }
+
+        public static bool EndsWith(this StringBuilder sb, char c)
+        {
+            return sb.Length > 0 && sb[sb.Length - 1] == c;
+        }
+
+        // Same count as scanning sb.ToString() without materializing the whole
+        // accumulated text into a fresh string.
+        public static int CountChar(this StringBuilder sb, char c)
+        {
+            var count = 0;
+#if NET8_0_OR_GREATER
+            foreach (var chunk in sb.GetChunks())
+            {
+                foreach (var ch in chunk.Span)
+                {
+                    if (ch == c)
+                    {
+                        count++;
+                    }
+                }
+            }
+#else
+            // GetChunks is missing from the netstandard2.1 reference assemblies.
+            for (var i = 0; i < sb.Length; i++)
+            {
+                if (sb[i] == c)
+                {
+                    count++;
+                }
+            }
+#endif
+            return count;
+        }
+
+        // Matches "{0:00}"/"{0:000}"-style formatting: sign first, then the absolute value
+        // padded with leading zeros to minDigits. Negates on a long so int.MinValue does
+        // not overflow.
+        public static void AppendNumber(this StringBuilder sb, int value, int minDigits)
+        {
+            var v = (long)value;
+            if (v < 0)
+            {
+                sb.Append('-');
+                v = -v;
+            }
+
+            var digitCount = 1;
+            for (var rest = v; rest >= 10; rest /= 10)
+            {
+                digitCount++;
+            }
+
+            for (; digitCount < minDigits; digitCount++)
+            {
+                sb.Append('0');
+            }
+
+            sb.Append(v);
+        }
+    }
+}

src/libse/Common/StringExtensions.cs

@@ -91,21 +91,11 @@ public static bool StartsWith(this string s, char c)
             return s.Length > 0 && s[0] == c;
         }
 
-        public static bool StartsWith(this StringBuilder sb, char c)
-        {
-            return sb.Length > 0 && sb[0] == c;
-        }
-
         public static bool EndsWith(this string s, char c)
         {
             return s.Length > 0 && s[s.Length - 1] == c;
         }
 
-        public static bool EndsWith(this StringBuilder sb, char c)
-        {
-            return sb.Length > 0 && sb[sb.Length - 1] == c;
-        }
-
         public static bool Contains(this string source, char value)
         {
             return source.IndexOf(value) >= 0;

src/libse/SubtitleFormats/AdvancedSubStationAlpha.cs

@@ -323,7 +323,7 @@ string HeaderTemplate() => headerTemplate ??= $@"[Script Info]
 
             // Trim inside the builder instead of "sb.ToString().Trim() + newline", which
             // allocated the whole multi-megabyte output twice more.
-            TrimBuilder(sb);
+            sb.Trim();
             return sb.Append(Environment.NewLine).ToString();
         }
 
@@ -340,13 +340,13 @@ private static StringBuilder AppendTimeCode(StringBuilder sb, TimeCode timeCode)
                 fragment = 0;
             }
 
-            AppendNumber(sb, ts.Days * 24 + ts.Hours, 1);
+            sb.AppendNumber(ts.Days * 24 + ts.Hours, 1);
             sb.Append(':');
-            AppendNumber(sb, ts.Minutes, 2);
+            sb.AppendNumber(ts.Minutes, 2);
             sb.Append(':');
-            AppendNumber(sb, ts.Seconds, 2);
+            sb.AppendNumber(ts.Seconds, 2);
             sb.Append('.');
-            AppendNumber(sb, fragment, 2);
+            sb.AppendNumber(fragment, 2);
             return sb;
         }
 
@@ -368,24 +368,6 @@ private static void AppendTextWithAssaNewLines(StringBuilder sb, string text)
             sb.Append(span);
         }
 
-        // Matches "{0:00}"-style formatting: sign first, then the absolute value padded with
-        // leading zeros to minDigits.
-        private static void AppendNumber(StringBuilder sb, int value, int minDigits)
-        {
-            if (value < 0)
-            {
-                sb.Append('-');
-                value = -value;
-            }
-
-            if (minDigits >= 2 && value < 10)
-            {
-                sb.Append('0');
-            }
-
-            sb.Append(value);
-        }
-
         public static string GetHeaderAndStylesFromSubStationAlpha(string header)
         {
             var scriptInfo = string.Empty;

src/libse/SubtitleFormats/SubRip.cs

@@ -72,7 +72,7 @@ public override string ToText(Subtitle subtitle, string title)
                 sb.Append(p.Text).Append(Environment.NewLine).Append(Environment.NewLine);
             }
 
-            TrimBuilder(sb);
+            sb.Trim();
             return sb.Append(Environment.NewLine).Append(Environment.NewLine).ToString();
         }
 

src/libse/SubtitleFormats/SubStationAlpha.cs

@@ -187,7 +187,7 @@ [V4 Styles]
 
             // Trim inside the builder instead of "sb.ToString().Trim() + newline", which
             // allocated the whole output twice more (same fix as [V4+ Styles]).
-            TrimBuilder(sb);
+            sb.Trim();
             return sb.Append(Environment.NewLine).ToString();
         }
 

src/libse/SubtitleFormats/SubtitleFormat.cs

@@ -563,29 +563,6 @@ public static int FramesToMillisecondsMax999(double frames)
         public bool BatchMode { get; set; }
         public double? BatchSourceFrameRate { get; set; }
 
-        /// <summary>
-        /// Trims leading/trailing whitespace inside the builder - the "sb.ToString().Trim()"
-        /// idiom in ToText implementations allocates the whole output an extra time.
-        /// </summary>
-        protected static void TrimBuilder(StringBuilder sb)
-        {
-            while (sb.Length > 0 && char.IsWhiteSpace(sb[sb.Length - 1]))
-            {
-                sb.Length--;
-            }
-
-            var start = 0;
-            while (start < sb.Length && char.IsWhiteSpace(sb[start]))
-            {
-                start++;
-            }
-
-            if (start > 0)
-            {
-                sb.Remove(0, start);
-            }
-        }
-
         public static string ToUtf8XmlString(XmlDocument xml, bool omitXmlDeclaration = false)
         {
             var settings = new XmlWriterSettings

src/libuilogic/Translate/MergeAndSplitHelper.cs

@@ -488,25 +488,6 @@ private static void InitializeFirstItem(MergeResult result, MergeContext context
         }
     }
 
-    // Same count as Utilities.CountTagInText(builder.ToString(), c) without materializing the
-    // whole accumulated text into a fresh string per merged row.
-    private static int CountChar(StringBuilder builder, char c)
-    {
-        var count = 0;
-        foreach (var chunk in builder.GetChunks())
-        {
-            foreach (var ch in chunk.Span)
-            {
-                if (ch == c)
-                {
-                    count++;
-                }
-            }
-        }
-
-        return count;
-    }
-
     private static readonly int NewLineUrlEncodeLength = Utilities.UrlEncodeLength(Environment.NewLine);
 
     private static bool ExceedsMaxSize(MergeResult result, MergeContext context, TranslateRow currentRow, int maxTextSize)
@@ -590,7 +571,7 @@ private static void ProcessEmptyRow(MergeResult result, MergeContext context, in
             context.CurrentItem.TextIndexStart = result.Text.Length;
             context.CurrentItem.TextIndexEnd = result.Text.Length;
             context.CurrentItem.EndChar = endChar;
-            context.CurrentItem.EndCharOccurrences = CountChar(context.TextBuilder, endChar);
+            context.CurrentItem.EndCharOccurrences = context.TextBuilder.CountChar(endChar);
             result.MergeResultItems.Add(context.CurrentItem);
         }
 
@@ -621,7 +602,7 @@ private static void ProcessSentenceEndingRow(MergeResult result, MergeContext co
             {
                 var endChar = result.Text[^1];
                 context.CurrentItem.EndChar = endChar;
-                context.CurrentItem.EndCharOccurrences = CountChar(context.TextBuilder, endChar);
+                context.CurrentItem.EndCharOccurrences = context.TextBuilder.CountChar(endChar);
                 context.CurrentItem.TextIndexEnd = result.Text.Length;
             }
 
@@ -681,7 +662,7 @@ private static void FinalizeResult(MergeResult result, MergeContext context)
             {
                 var endChar = result.Text[^1];
                 context.CurrentItem.EndChar = endChar;
-                context.CurrentItem.EndCharOccurrences = CountChar(context.TextBuilder, endChar);
+                context.CurrentItem.EndCharOccurrences = context.TextBuilder.CountChar(endChar);
             }
         }