Skip to content

adding stalkernet button for Carleton version - #8815

Open
aureliapr wants to merge 7 commits into
StoDevX:masterfrom
kreed303:main
Open

aureliapr wants to merge 7 commits into
StoDevX:masterfrom
kreed303:main

Conversation

@aureliapr

@aureliapr aureliapr commented Nov 3, 2026 •

Copy link
Copy Markdown

Summary

My lord, the Carleton contacts screen and tile are now titled “Contacts.” A separate “Directory” tile opens Carleton’s web directory in a browser. Tests now check the updated labels and link behavior.

The mise.lock and pnpm-lock.yaml files also changed. The diff does not establish why.

Checks

CI and test results: not available. Review finding counts: not available.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

hlāford, Carleton’s contacts tile is now named Contacts. A separate Directory URL tile links to Carleton’s web directory.

Changes: Carleton hām-tīlas

Layer / File(s) Summary
Contacts nama and Directory URL
source/campuses/edu-carleton.ts, source/campuses/edu-carleton/home-tiles.ts
Þæt contacts-view-tīl is named Contacts. A separate Directory URL tile is added with a person icon and red gradient.
Tile tests and expected names
source/campuses/__tests__/sections.test.ts, source/features/__tests__/views.test.ts, source/features/quick-actions/__tests__/destinations.test.ts, uitests/CampusSmokeTests.swift
Þā tests expect Contacts for the contacts tile. Þā view tests check that the Directory tile is a URL view, has the person.fill icon, and opens in a browser.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: Minimal · previous review 31ff5

The Contacts rename and Directory browser tile are consistent with their consumers and tests; the change is mergeable pending normal checks.

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d89fbe6-75bd-448c-8db4-baed968ce356
Commits

Reviewing files that changed from the base of the PR and between e33f1e2 and 31ff508.

Files ignored due to path filters: 2

  • mise.lock is excluded by !**/*.lock
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 6

  • source/campuses/__tests__/sections.test.ts
  • source/campuses/edu-carleton.ts
  • source/campuses/edu-carleton/home-tiles.ts
  • source/features/__tests__/views.test.ts
  • source/features/quick-actions/__tests__/destinations.test.ts
  • uitests/CampusSmokeTests.swift
Files skipped from review as they are similar to previous changes: 1

  • source/campuses/edu-carleton/home-tiles.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

{
type: 'url',
url: 'https://www.carleton.edu/directory/',
title: 'Stalkernet',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been asked that we call this "Directory" for CARLS – and I seem to recall that you were also interested in changing that?

We can do it now or later, just wanted to throw that out there.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change that now

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CARLS already has a Directory tile, there are a few options on what we could do here

  • Rename the previous 'Directory' to 'Contacts'?
  • Hide the old one with disabled, but keep the code?
  • Open the native /contacts view, and add a row for opening the webview within /contacts, and show it depending on the campus via useCampus?
  • ...something else?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the previous directory to contacts and rename stalkernet to directory

@drewvolz

drewvolz commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Nice! I'm seeing unexpected changes to mise lockfiles due to different versions of mise. Going to add a min_version=2026.9.16 to the lockfile in a separate PR, then merge those changes into your branch, which should help make those go away.

drewvolz pushed a commit to kreed303/AAO-React-Native-Comps that referenced this pull request Nov 5, 2026
An older mise rewrites mise.lock as format 2 whenever it touches it,
dropping the forge repository IDs and re-resolving other entries, as
happened in StoDevX#8815.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014hjTWsKqaVDxtgQPH25MXi

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants