Repository navigation
Offer the windmills as CARLS alternate icons - #8740
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Test Results SummaryThis comment shows the latest test results for this pull request.
|
|
Important Needs a new native build, not a JS reload. Check Info.plist, entitlements and the privacy manifest by hand.
Note No app size for the base branch to compare with. No app size to compare with, so the app size gate passes.
JS bundle
Compared with |
131e058 to
ce22001
Compare
78efa56 to
d53b21a
Compare
201d6b3 to
1b97476
Compare
d53b21a to
c15a531
Compare
1b97476 to
bb4e8a7
Compare
c15a531 to
0a49f68
Compare
Stacked on #8739.
Before: CARLS bundled no alternate icons, so Carleton's App Icon gallery offered only the penguin. A St. Olaf icon chosen before switching to Carleton always became the penguin.
After: every variant bundles every icon except its own primary. Carleton's gallery offers the penguin, then the three windmills (Sky, Dawn, Golden Hour). A windmill stays on when you switch to Carleton. Classic icons such as Old Main still move to the penguin.
How:
plugins/with-alternate-iconsnow takes{primary}and bundles everything inICON_DOCUMENTSandSTATIC_ICON_SETSexcept that primary (alternatesFor). Each variant inapp.config.tsnames itsprimaryIconand passes it to the plugin and toextra.primaryIcon.DEFAULT_ICONreads it throughPRIMARY_ICONinapp-identity.ts, so it no longer branches on the app. Carleton'sappIcons.groupsgainsWindmill. AGENTS.md and the CARLS Builds doc are updated to match.🤖 Generated with Claude Code
https://claude.ai/code/session_01Bb3rKQ6pVnsk4bTcpjgiWr
Generated by Claude Code