Skip to content

Offer the windmills as CARLS alternate icons - #8740

Merged
hawkrives merged 0 commit into
claude/project-thread-ydd044-4from
claude/project-thread-ydd044-5
Oct 10, 2026
Merged

hawkrives merged 0 commit into
claude/project-thread-ydd044-4from
claude/project-thread-ydd044-5

Conversation

@hawkrives

Copy link
Copy Markdown
Member

Stacked on #8739.

Before: CARLS bundled no alternate icons, so Carleton's App Icon gallery offered only the penguin. A St. Olaf icon chosen before switching to Carleton always became the penguin.

After: every variant bundles every icon except its own primary. Carleton's gallery offers the penguin, then the three windmills (Sky, Dawn, Golden Hour). A windmill stays on when you switch to Carleton. Classic icons such as Old Main still move to the penguin.

How: plugins/with-alternate-icons now takes {primary} and bundles everything in ICON_DOCUMENTS and STATIC_ICON_SETS except that primary (alternatesFor). Each variant in app.config.ts names its primaryIcon and passes it to the plugin and to extra.primaryIcon. DEFAULT_ICON reads it through PRIMARY_ICON in app-identity.ts, so it no longer branches on the app. Carleton's appIcons.groups gains Windmill. AGENTS.md and the CARLS Builds doc are updated to match.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bb3rKQ6pVnsk4bTcpjgiWr


Generated by Claude Code

@hawkrives hawkrives added the claude Found or filed by Claude label Oct 10, 2026 — with Claude
@hawkrives hawkrives self-assigned this Oct 10, 2026
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3d609e7-3930-4034-8698-5dec708d05cd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@flakiness-io

flakiness-io Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
0a49f68 ✅ Passed 6408 passed · 1 flaky · 2 skipped 4 runs
⚠️ 1 flaky

⚠️ iOS 27.0 · iOS Simulator ExampleCollegeTests › testHomeIsWikiMonkeys()

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Needs a native build · JS -323 B (<0.01%)

Important

Needs a new native build, not a JS reload. Check Info.plist, entitlements and the privacy manifest by hand.

  • App config and plugins: app.config.ts, plugins/with-alternate-icons.ts

Note

No app size for the base branch to compare with. No app size to compare with, so the app size gate passes.

Size Change
JS · Hermes bytecode 9.02 MiB -323 B (<0.01%)
App install · iPhone18,3 63.64 MiB
App download 29.32 MiB
App with JS and images 75.19 MiB
node_modules 626.29 MiB —
Published data (gzipped) 39.3 KiB —
Published images 2.20 MiB —

JS bundle

Changed most Before After Δ
(app) 1.53 MiB 1.53 MiB +254 B
Features changed most Before After Δ
(other) 325.7 KiB 325.9 KiB +235 B
customize 3.1 KiB 3.1 KiB +19 B

Compared with claude/project-thread-ydd044-4, this PR's base branch, at 1b97476. Package and feature sizes are minified JS from the source map; the gate uses bytecode.

@hawkrives
hawkrives force-pushed the claude/project-thread-ydd044-4 branch from 131e058 to ce22001 Compare October 10, 2026 06:25
@hawkrives
hawkrives force-pushed the claude/project-thread-ydd044-5 branch from 78efa56 to d53b21a Compare October 10, 2026 06:25
@hawkrives
hawkrives marked this pull request as ready for review October 10, 2026 06:33
@hawkrives
hawkrives requested a review from rye as a code owner October 10, 2026 06:33
@hawkrives
hawkrives force-pushed the claude/project-thread-ydd044-4 branch from 201d6b3 to 1b97476 Compare October 10, 2026 06:42
@hawkrives
hawkrives force-pushed the claude/project-thread-ydd044-5 branch from d53b21a to c15a531 Compare October 10, 2026 06:42
@hawkrives
hawkrives merged commit 0a49f68 into claude/project-thread-ydd044-4 Oct 10, 2026
@hawkrives
hawkrives force-pushed the claude/project-thread-ydd044-4 branch from 1b97476 to bb4e8a7 Compare October 10, 2026 06:55
@hawkrives
hawkrives deleted the claude/project-thread-ydd044-5 branch October 10, 2026 06:55
@hawkrives
hawkrives force-pushed the claude/project-thread-ydd044-5 branch from c15a531 to 0a49f68 Compare October 10, 2026 06:55
@hawkrives
hawkrives restored the claude/project-thread-ydd044-5 branch October 10, 2026 06:56
@hawkrives
hawkrives deleted the claude/project-thread-ydd044-5 branch October 10, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude Found or filed by Claude

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants