Skip to content

[Test] Generate Franka Pour resets for contrib smoke test - #3

Merged
StafaH merged 1 commit into
StafaH:mh/test-contrib-environmentsfrom
maxkra15:agent/generate-pour-reset-dataset-for-tests
Aug 13, 2026
Merged

[Test] Generate Franka Pour resets for contrib smoke test#3
StafaH merged 1 commit into
StafaH:mh/test-contrib-environmentsfrom
maxkra15:agent/generate-pour-reset-dataset-for-tests

Conversation

@maxkra15

Copy link
Copy Markdown

Summary

  • Generate the smallest valid Franka Pour reset dataset on demand for its contributed-environment smoke case.
  • Reuse the shipped generator and its default artifact path, and skip generation when an artifact already exists.
  • Keep the task, generator defaults, and all user-facing runtime behavior unchanged.

Root cause

isaac-sim#7068 removes the former explicit Franka Pour skip and exercises the task from a clean checkout, where the intentionally ignored reset artifact is absent. The environment therefore raises FileNotFoundError before the random-action smoke rollout begins.

This PR is stacked directly on the head of isaac-sim#7068 so it contains only the focused test fix.

Validation

  • Started without datasets/franka_pour/reset_dataset.pt.
  • Ran test_contrib_environments[IsaacContrib-Franka-Pour-2-cuda] directly.
  • Result: 1 passed, 304 deselected in 41.44 seconds.
  • The test generated a validated 106-row, 42,245-byte artifact and then successfully created and stepped the Pour environment.
  • Ruff, Ruff format, whitespace, spelling, license, YAML/TOML, conflict, private-key, debug-statement, and Git LFS hooks passed. The full changelog hook remains blocked by pre-existing divergence in the stacked base branch.

@maxkra15
maxkra15 marked this pull request as ready for review August 13, 2026 16:47
@StafaH
StafaH merged commit 366ae4c into StafaH:mh/test-contrib-environments Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants