ECHOES-1455 Allow scroll in left panel of FilterDropdown at 400px

[kimphanh]

Use in my dev branch

Part of

---

Summary by Gitar

• UI styling updates:
  • Updated maxHeight default value to 400px in base design tokens

_{This will update automatically on new commits.}

[netlify]

✅ Deploy Preview for echoes-react ready!

Name	Link
🔨 Latest commit	9b23db2
🔍 Latest deploy log	https://app.netlify.com/projects/echoes-react/deploys/6a9152e602dce10008cf72dd
😎 Deploy Preview	https://deploy-preview-760--echoes-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hashicorp-vault-sonar-prod]

ECHOES-1455

✅ All code review findings resolved.

_{Configure merge blocking}

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Updates the FilterDropdown left panel maxHeight default value to 400px in the design tokens, enabling scroll behavior at smaller viewport sizes. No issues found.

✅ 1 resolved

✅ Bug: Generated token file hand-edited; source token still 600px

📄 src/generated/design-tokens-base.json:106 📄 design-tokens/tokens/component/base.json:40-45
src/generated/design-tokens-base.json is build output of yarn build-tokens (design-tokens/build.js) from design-tokens/tokens/**, where echoes.filter.dropdown.sizes.maxHeight.default is still 600px (design-tokens/tokens/component/base.json:40-45). Three consequences follow from editing only the generated JSON: (1) the change has no runtime effect — FilterDropdownStyles.ts:38 uses cssVar(...), which emits var(--echoes-filter-dropdown-sizes-max-height-default) resolved from src/generated/design-tokens-base.css:128, still 600px, so the dropdown never clamps to 400px and the left panel still does not scroll as the PR intends; (2) CI fails — yarn validate-ci → tokens-check → config/scripts/validate-tokens.sh rebuilds tokens and runs git diff --quiet src/generated, which now reports a diff because the regenerated JSON reverts to 600px; (3) the JSON and CSS artifacts disagree, so designToken('filter-dropdown-sizes-max-height-default') (src/utils/design-tokens.ts:81) returns 400px while the applied CSS is 600px. Fix by changing the source token and regenerating, leaving src/generated/ untouched by hand.

Implementation Status ✅ 1 of 1 objectives covered

✅ ECHOES-1455 - 1 of 1 objectives covered

This PR changes the echoes-filter-dropdown-sizes-max-height-default design token value from 600px to 400px.

✅ 1 covered here

• ✅ Change echoes-filter-dropdown-sizes-max-height-default to 400px instead of 600px to allow scroll in the left panel of FilterDropdown

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube