Skip to content

GROW-367 Add the Data Usage icon to the icon library - #758

Open
MoukhtarZBV wants to merge 1 commit into
mainfrom
mz/grow-367/feat/add-data-usage-icon
Open

GROW-367 Add the Data Usage icon to the icon library#758
MoukhtarZBV wants to merge 1 commit into
mainfrom
mz/grow-367/feat/add-data-usage-icon

Conversation

@MoukhtarZBV

@MoukhtarZBV MoukhtarZBV commented Aug 27, 2026

Copy link
Copy Markdown

Summary

Adds IconDataUsage (Material Symbols data_usage, codepoint e1af) to the icon library. This icon will be used in the 'Project Coverage' menu item inside the SQS administration tab, as per GROW-363.

@netlify

netlify Bot commented Aug 27, 2026

Copy link
Copy Markdown

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 5ef6a8b
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a9000e79fcdd20008479bd9
😎 Deploy Preview https://deploy-preview-758--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Aug 27, 2026

Copy link
Copy Markdown

GROW-367

Comment thread src/components/icons/IconDataUsage.tsx
@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds the IconDataUsage component to the icon library for the Project Coverage menu item. No issues found.

✅ 1 resolved
Quality: New icon component uses deprecated forwardRef under React 19

📄 src/components/icons/IconDataUsage.tsx:21 📄 src/components/icons/IconDataUsage.tsx:24-31
IconDataUsage is a newly added component that wraps its body in forwardRef, which is deprecated in React 19 (the repo pins react: ^19.0.0 in peerDependencies) — ref is a regular prop and should be accepted via props destructuring. No functional impact today, but it adds a 132nd site to migrate. Note the real root cause is the generator template at config/scripts/create-icon.js:164, which still emits forwardRef for every scaffolded icon; fixing the template (and the 131 existing icons) is the durable fix, so this is not a blocker for this PR alone.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

@MoukhtarZBV MoukhtarZBV changed the title GROW-367 Add the Data Usage icon to the icon library [] Add the Data Usage icon to the icon library Aug 27, 2026
@MoukhtarZBV MoukhtarZBV changed the title [] Add the Data Usage icon to the icon library GROW-367 Add the Data Usage icon to the icon library Aug 27, 2026
@MoukhtarZBV
MoukhtarZBV marked this pull request as ready for review August 27, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant