ECHOES-1452 Add and rely on an id for FilterDropdownCategory - #756
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review ✅ Approved 1 resolved / 1 findingsAdds a required id property to FilterDropdownCategory for component keys and callbacks. Consider updating the right panel to use the new id instead of the active category index. ✅ 1 resolved✅ Quality: Right panel still keyed by index after id was introduced
Implementation Status ✅ 2 of 2 objectives covered✅ ECHOES-1452 - 2 of 2 objectives coveredThis PR adds an id property to FilterDropdownCategory and updates FilterDropdown to rely on the category id instead of its label. ✅ 2 covered here
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|




Part of
Summary by Gitar
idproperty toFilterDropdownCategorytypes and updated component keys and callbacks to rely on it instead oflabelThis will update automatically on new commits.