Skip to content

ECHOES-397 Add issue location marker layer 3 tokens #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2amelia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ECHOES-397 Add issue location marker layer 3 tokens #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c663d87
ECHOES-397 Add location marker semantic tokens
2amelia Aug 2, 2026
7c8696e
ECHOES-397 Rename location marker tokens
2amelia Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions design-tokens/tokens/component/dark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,52 @@
}
}
},
"issue-location-marker": {
"colors": {
"background": {
"default": {
"$extensions": {
"studio.tokens": {
"modify": {
"type": "alpha",
"value": "0.35",
"space": "lch"
}
}
},
"$type": "color",
"$value": "{echoes.color.palette.red.400}"
Comment on lines +59 to +73

@gitar-bot gitar-bot Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Quality: New issue-location-marker design tokens need designer+dev review

This PR introduces new layer-3 semantic design tokens (issue-location-marker.colors.background.{default,hover,selected} and foreground.{default,selected}) in both light.json and dark.json. Per the design-token review policy, new tokens should be reviewed by both a designer and a developer as a checkpoint (not a blocker) to confirm the token contract, naming, and palette/alpha choices are intentional. The generated outputs (dark uses alpha-modified red.400 for background default/hover and red.200 for selected/foreground; light uses solid red palette values) appear consistent, so this is just the recommended sign-off.

Was this helpful? React with 👍 / 👎

},
"hover": {
"$extensions": {
"studio.tokens": {
"modify": {
"type": "alpha",
"value": "0.65",
"space": "lch"
}
}
},
"$type": "color",
"$value": "{echoes.color.palette.red.400}"
},
"selected": {
"$type": "color",
"$value": "{echoes.color.palette.red.200}"
}
},
"foreground": {
"default": {
"$type": "color",
"$value": "{echoes.color.palette.red.200}"
},
"selected": {
"$type": "color",
"$value": "{echoes.color.palette.red.700}"
}
}
}
},
"margin-indicator": {
"colors": {
"background": {
Expand Down
28 changes: 28 additions & 0 deletions design-tokens/tokens/component/light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,34 @@
}
}
},
"issue-location-marker": {
"colors": {
"background": {
"default": {
"$type": "color",
"$value": "{echoes.color.palette.red.200}"
},
"hover": {
"$type": "color",
"$value": "{echoes.color.palette.red.300}"
},
"selected": {
"$type": "color",
"$value": "{echoes.color.palette.red.600}"
}
},
"foreground": {
"default": {
"$type": "color",
"$value": "{echoes.color.palette.red.700}"
},
"selected": {
"$type": "color",
"$value": "{echoes.color.palette.red.100}"
}
}
}
},
"margin-indicator": {
"colors": {
"background": {
Expand Down
5 changes: 5 additions & 0 deletions src/generated/design-tokens-dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ html[data-echoes-theme='dark'], [data-echoes-theme='dark'] {
--echoes-logos-colors-text: #ffffff;
--echoes-logos-colors-brand: #ffffff;
--echoes-logos-colors-sonar-whale: #d3121d;
--echoes-issue-location-marker-colors-background-default: #f9706659;
--echoes-issue-location-marker-colors-background-hover: #f97066a6;
--echoes-issue-location-marker-colors-background-selected: #fecdca;
--echoes-issue-location-marker-colors-foreground-default: #fecdca;
--echoes-issue-location-marker-colors-foreground-selected: #b42318;
--echoes-margin-indicator-colors-background-duplication: #a6adc2;
--echoes-margin-indicator-colors-background-covered: #d4f2b7;
--echoes-margin-indicator-colors-background-partially-covered: #fadc79;
Expand Down
5 changes: 5 additions & 0 deletions src/generated/design-tokens-light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@
--echoes-logos-colors-text: #290042;
--echoes-logos-colors-brand: #126ed3;
--echoes-logos-colors-sonar-whale: #d3121d;
--echoes-issue-location-marker-colors-background-default: #fecdca;
--echoes-issue-location-marker-colors-background-hover: #fda29b;
--echoes-issue-location-marker-colors-background-selected: #d92d20;
--echoes-issue-location-marker-colors-foreground-default: #b42318;
--echoes-issue-location-marker-colors-foreground-selected: #fee4e2;
--echoes-margin-indicator-colors-background-duplication: #c5cddf;
--echoes-margin-indicator-colors-background-covered: #75a92c;
--echoes-margin-indicator-colors-background-partially-covered: #ae7a29;
Expand Down
5 changes: 5 additions & 0 deletions src/generated/design-tokens-themed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@
"echoes-logos-colors-text": "#290042",
"echoes-logos-colors-brand": "#126ed3",
"echoes-logos-colors-sonar-whale": "#d3121d",
"echoes-issue-location-marker-colors-background-default": "#fecdca",
"echoes-issue-location-marker-colors-background-hover": "#fda29b",
"echoes-issue-location-marker-colors-background-selected": "#d92d20",
"echoes-issue-location-marker-colors-foreground-default": "#b42318",
"echoes-issue-location-marker-colors-foreground-selected": "#fee4e2",
"echoes-margin-indicator-colors-background-duplication": "#c5cddf",
"echoes-margin-indicator-colors-background-covered": "#75a92c",
"echoes-margin-indicator-colors-background-partially-covered": "#ae7a29",
Expand Down
3 changes: 3 additions & 0 deletions src/utils/__tests__/design-tokens-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ describe('cssVar utility', () => {
);
expect(cssVar(FONT_TOKEN)).toBe('var(--echoes-font-family-sans)');
expect(cssVar('border-radius-100')).toBe('var(--echoes-border-radius-100)');
expect(cssVar('issue-location-marker-colors-background-default')).toBe(
'var(--echoes-issue-location-marker-colors-background-default)',
);
});

it('should handle complex fallback values', () => {
Expand Down
Loading