-
Notifications
You must be signed in to change notification settings - Fork 0
fix: make container widths responsive for consistent large-screen alignment #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
a1313c0
0c40108
8312a15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,9 +12,9 @@ const quickLinks = [ | |
| export function Footer() { | ||
| return ( | ||
| <footer className="overflow-hidden bg-white text-ma-text"> | ||
| <div className="relative mx-auto min-h-125 max-w-360 px-4 pt-12.5 lg:px-25 lg:pt-17.5 2xl:px-50"> | ||
| <div className="grid gap-10 md:grid-cols-[254px_180px_1fr] md:gap-[100px] lg:gap-[120px]"> | ||
| <section> | ||
| <div className="relative mx-auto min-h-125 px-4 pt-12.5 lg:max-w-7xl lg:px-25 lg:pt-17.5 2xl:max-w-360 2xl:px-50"> | ||
| <div className="grid gap-10 text-center md:grid-cols-[0.9fr_0.6fr_1.5fr] md:text-left lg:gap-10 xl:grid-cols-[254px_180px_1fr] xl:gap-[125px]"> | ||
| <section className=""> | ||
| <h2 className="font-sans text-lg font-extrabold lg:text-2xl"> | ||
| Get in Touch | ||
| </h2> | ||
|
|
@@ -63,12 +63,12 @@ export function Footer() { | |
| <h2 className="font-sans text-lg font-extrabold lg:text-2xl"> | ||
| Join our News letter | ||
| </h2> | ||
| <p className="mt-5 max-w-[387px] text-sm leading-normal"> | ||
| <p className="mt-5 text-sm leading-normal xl:max-w-[387px]"> | ||
| Stay connected and informed: Join our newsletter for the latest | ||
| updates, inspiration, and design insights. | ||
| </p> | ||
|
|
||
| <form className="mt-6 flex w-full max-w-[374px] items-center justify-between rounded-[60px] bg-[#f5f5f5] py-2.5 pr-2.5 pl-5"> | ||
| <form className="mt-6 flex w-full items-center justify-between rounded-[60px] bg-[#f5f5f5] py-2.5 pr-2.5 pl-5 lg:max-w-[374px]"> | ||
| <label htmlFor="footer-email" className="sr-only"> | ||
| Email address | ||
| </label> | ||
|
|
@@ -99,7 +99,7 @@ export function Footer() { | |
| </section> | ||
| </div> | ||
|
|
||
| <p className="pointer-events-none mt-10 bg-gradient-to-b from-ma-text from-[40%] to-ma-text/0 to-[74%] bg-clip-text font-heading text-[40px] leading-none font-extrabold whitespace-nowrap text-transparent select-none lg:absolute lg:top-[370px] lg:left-1/2 lg:-translate-x-1/2 lg:text-[124px]"> | ||
| <p className="pointer-events-none left-1/2 mt-10 translate-x-[20%] bg-gradient-to-b from-ma-text from-[40%] to-ma-text/0 to-[74%] bg-clip-text font-heading text-[40px] leading-none font-extrabold whitespace-nowrap text-transparent select-none lg:absolute lg:top-[370px] lg:left-1/2 lg:-translate-x-[calc(1280px/2-100px)] lg:text-[100px] xl:text-[124px] 2xl:-translate-x-[calc(1280px/2-116px)]"> | ||
| ModernAdvocates | ||
| </p> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '\n== footer slice ==\n'
sed -n '1,220p' src/features/marketing/components/footer.tsx
printf '\n== search max-w-360 ==\n'
rg -n "max-w-360|1280px/2-116px|1440px/2|calc\\(" src -SRepository: Smartlify07/Modern-Advocates Length of output: 12534 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '\n== footer slice ==\n'
sed -n '1,220p' src/features/marketing/components/footer.tsx
printf '\n== search max-w-360 and related config ==\n'
rg -n "max-w-360|1280px/2-116px|1440px/2|maxWidth|container" -S . --glob '!**/node_modules/**'Repository: Smartlify07/Modern-Advocates Length of output: 9310 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '\n== tailwind/theme config files ==\n'
fd -a "tailwind*|postcss*|globals.css|theme.*|config.*" .
printf '\n== search for 360 width token ==\n'
rg -n "360|7xl|max-w-360|maxWidth|spacing" -S tailwind.config.* src app . --glob '!**/node_modules/**' --glob '!**/pnpm-lock.yaml'
printf '\n== search for custom maxWidth definitions ==\n'
rg -n "maxWidth:|theme:|extend:" -S . --glob '!**/node_modules/**' --glob '!**/pnpm-lock.yaml'Repository: Smartlify07/Modern-Advocates Length of output: 27208 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '\n== globals.css theme section ==\n'
sed -n '1,260p' src/app/globals.css
printf '\n== search for max-w-360 token definition ==\n'
rg -n "`@theme`|--container-360|max-w-360|360rem|1440px|1280px" src/app src -S
printf '\n== search for tailwind config files ==\n'
fd -a 'tailwind.config.*|tailwind.*.*|*.config.*' .
printf '\n== search for custom container widths in css ==\n'
rg -n "container|max-width|--container|--breakpoint" src/app src -SRepository: Smartlify07/Modern-Advocates Length of output: 9325 🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n "1280px/2-|1440px/2-|calc\\(1280px/2|calc\\(1440px/2" src -SRepository: Smartlify07/Modern-Advocates Length of output: 618 🌐 Web query:
💡 Result: In Tailwind CSS v4, the spacing system was fundamentally redesigned to move away from a fixed, predefined list of scale values toward a dynamic multiplier-based system [1]. Default Spacing Scale By default, Tailwind CSS v4 defines a single base unit in the CSS Citations:
Adjust the 2xl heading offset to the 1440px container. In 🤖 Prompt for AI Agents |
||
| </div> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: Smartlify07/Modern-Advocates
Length of output: 5155
Align the newsletter copy and form widths. The paragraph stays unconstrained until
xl, while the form is capped atlg, so the section can look uneven between 1024–1279px. Cap the paragraph atlgas well.🤖 Prompt for AI Agents