-
Notifications
You must be signed in to change notification settings - Fork 0
feat: donation form API wiring and shared marketing container #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 19 commits
955345b
411a585
f1e8f34
0cceb9a
6125f6d
c9c8374
2ef5027
9adaa6a
be6c729
78e0b76
753d7b4
ed155ee
94c21e8
35a375f
b549ce4
c17e01f
01e8b82
123073c
8008dc6
b732cca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,24 @@ type CourseContentData = { | |
| avgRating: number | ||
| reviewCount: number | ||
| enrollmentCount: number | ||
| modules: { id: string; title: string; sortOrder: number; topics: { id: string; title: string; format: string; content: string | null }[] }[] | ||
| reviews: { id: string; body: string | null; rating: number; studentName: string | null; studentImage: string | null }[] | ||
| modules: { | ||
| id: string | ||
| title: string | ||
| sortOrder: number | ||
| topics: { | ||
| id: string | ||
| title: string | ||
| format: string | ||
| content: string | null | ||
| }[] | ||
| }[] | ||
| reviews: { | ||
| id: string | ||
| body: string | null | ||
| rating: number | ||
| studentName: string | null | ||
| studentImage: string | null | ||
| }[] | ||
|
Comment on lines
+25
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Move
As per coding guidelines, do not redefine DTOs or query keys in multiple places. 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| } | ||
|
|
||
| export function CourseDetailContentSection({ | ||
|
|
@@ -33,7 +49,7 @@ export function CourseDetailContentSection({ | |
| }) { | ||
| return ( | ||
| <section className="bg-white py-10 text-ma-text lg:py-20"> | ||
| <div className="mx-auto flex flex-col-reverse gap-12 px-4 lg:grid lg:max-w-7xl lg:grid-cols-[0.6fr_0.4fr] lg:items-start lg:justify-between lg:px-25 xl:grid-cols-[598px_335px] 2xl:max-w-360 2xl:px-50"> | ||
| <div className="marketing-container flex flex-col-reverse gap-12 py-0! sm:py-0 lg:grid lg:grid-cols-[0.6fr_0.4fr] lg:items-start lg:justify-between xl:grid-cols-[598px_335px] 2xl:grid-cols-[650px_400px]"> | ||
| <div className="flex w-full max-w-[598px] flex-col gap-[30px]"> | ||
| <section className="flex flex-col gap-4"> | ||
| <h2 className="text-xl/[100%] leading-normal font-extrabold text-ma-text sm:text-2xl"> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use a design-token width for the loading card.
Line 80 changes the card width to another bracketed arbitrary value,
sm:max-w-[300px]. Replace it with the repository’s named width token for 300px, or define that token before using it.As per coding guidelines: “Do not use arbitrary hex colors or spacing; use the repository's design tokens.”
🤖 Prompt for AI Agents
Source: Coding guidelines