Skip to content

Entity Migration - #8410

Merged
APickledWalrus merged 61 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/EntityDataInfoMove
Oct 1, 2026
Merged

APickledWalrus merged 61 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/EntityDataInfoMove

Conversation

@Absolutionism

@Absolutionism Absolutionism commented Jan 27, 2026 •

Copy link
Copy Markdown
Contributor

Problem

SyntaxElement classes using deprecated registration methods
EntityDataInfo extended deprecated SyntaxElementInfo
Classes were not in org

Solution

Migrate all EntityData classes to 'entity' package and made modules for those who have SyntaxElements that only work for one entity.
Updated EntityDataInfo to implement SyntaxInfo, with corresponding behavior.

Testing Completed

Existing test files + test actions

Supporting Information

Breaking Changes

  • Migration
  • EntityDataInfo field access and class generics

Completes: none
Related: none
AI assistance: SovdeBot 100%

@Absolutionism
Absolutionism requested review from a team and sovdeeth as code owners January 27, 2026 00:46
@Absolutionism
Absolutionism requested review from UnderscoreTud and removed request for a team January 27, 2026 00:46
@skriptlang-automation skriptlang-automation Bot added the needs reviews A PR that needs additional reviews label Jan 27, 2026
@Absolutionism Absolutionism added the breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) label Jan 27, 2026

@sovdeeth sovdeeth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

116/233

Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/allay/EffAllayDuplicate.java Outdated
Comment thread src/main/java/ch/njol/skript/entity/WolfData.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityDataInfo.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityDataInfo.java Outdated

@APickledWalrus APickledWalrus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly ready!!

Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityDataClassInfo.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityDataInfoImpl.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityType.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityType.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityType.java
Comment thread src/main/java/org/skriptlang/skript/localization/GeneralNoun.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/data/SimpleEntityData.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityData.java
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityData.java Outdated
Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityData.java Outdated
…taInfoMove

# Conflicts:
#	src/main/java/org/skriptlang/skript/bukkit/entity/EntityModule.java

@APickledWalrus APickledWalrus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good enough at this point

Comment thread src/main/java/org/skriptlang/skript/bukkit/entity/EntityData.java Outdated
…taInfoMove

# Conflicts:
#	src/main/java/ch/njol/skript/classes/data/DefaultComparators.java
#	src/main/java/ch/njol/skript/entity/SimpleEntityData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/CatData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/ChickenData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/CowData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/DroppedItemData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/FrogData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/PigData.java
#	src/main/java/org/skriptlang/skript/bukkit/entity/data/WolfData.java
#	src/main/resources/lang/default.lang
…taInfoMove

# Conflicts:
#	src/main/java/ch/njol/skript/classes/data/DefaultComparators.java
#	src/main/java/ch/njol/skript/entity/SimpleEntityData.java
#	src/main/resources/lang/default.lang
@skriptlang-automation skriptlang-automation Bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Oct 1, 2026
@APickledWalrus
APickledWalrus merged commit e6fa78f into SkriptLang:dev/feature Oct 1, 2026
11 checks passed
@skriptlang-automation skriptlang-automation Bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Oct 1, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Merge to Done - Awaiting Release in 2.17 Releases Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

4 participants