chore(frontend): update to Node 24 LTS - #13492
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 PR Overlap DetectionThis check compares your PR against all other open PRs targeting the same branch to detect potential merge conflicts early. 🟢 Low Risk — File Overlap OnlyThese PRs touch the same files but different sections (click to expand)
Summary: 0 conflict(s), 0 medium risk, 5 low risk (out of 5 PRs with file overlap) Auto-generated on push. Ignores: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #13492 +/- ##
==========================================
- Coverage 75.05% 75.02% -0.04%
==========================================
Files 2610 2610
Lines 194823 194825 +2
Branches 19166 19165 -1
==========================================
- Hits 146222 146160 -62
- Misses 44430 44490 +60
- Partials 4171 4175 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…d engines Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The frontend has required Node 24 since #13492 (engines.node 24.x with engine-strict=true), but the root .nvmrc still pins 22 — so nvm users and any tooling that resolves the nearest .nvmrc get a Node that can no longer install the frontend. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AxWtuJtGyjBYUdWTvuWffp
…s#13602) ### Background Significant-Gravitas#13492 moved the frontend to Node 24 LTS (`engines.node: 24.x`, enforced by `engine-strict=true` in `.npmrc`), but the root `.nvmrc` still pins **22**. Anyone running `nvm use` from the repo root — or any tooling that resolves the nearest `.nvmrc` — ends up on a Node that can no longer `pnpm install` the frontend: ``` ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version) Expected version: 24.x Got: v22.x ``` This stale pin also sent the PR-review automation down the wrong Node version until it learned to distrust it. ### Changes 🏗️ - Bump root `.nvmrc` from `22` to `24`, matching the frontend's engines requirement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01AxWtuJtGyjBYUdWTvuWffp <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Single-line tooling pin only; no runtime, auth, or application logic changes. > > **Overview** > Updates the **root** `.nvmrc` from **22** to **24** so `nvm use` and other nearest-`.nvmrc` resolution match the frontend’s **`engines.node: 24.x`** (and `engine-strict` installs). > > This removes the mismatch where developers on Node 22 at the repo root hit `ERR_PNPM_UNSUPPORTED_ENGINE` when installing or working on the frontend. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 11f6362. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Why / What / How
The above bro ☝🏽
Checklist 📋
For code changes: